Skip to content

Commit 99b7676

Browse files
updated code for github actions (#4)
* updated the code as per baeldung guidelines * updated env variable names
1 parent 463e158 commit 99b7676

File tree

5 files changed

+18
-22
lines changed

5 files changed

+18
-22
lines changed

src/test/java/com/baeldung/BaseTest.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,24 @@ public class BaseTest {
1717

1818
@BeforeTest
1919
public void setup() {
20-
final String userName = System.getenv("LT_USERNAME") == null ? "LT_USERNAME" : System.getenv("LT_USERNAME");
21-
final String accessKey = System.getenv("LT_ACCESS_KEY") == null ? "LT_ACCESS_KEY" : System.getenv("LT_ACCESS_KEY");
22-
final String gridUrl = "@hub.lambdatest.com/wd/hub";
20+
String userName = System.getenv("LAMBDATEST_USERNAME") == null ? "LAMBDATEST_USERNAME" : System.getenv(
21+
"LT_USERNAME");
22+
String accessKey = System.getenv("LAMBDATEST_ACCESS_KEY") == null ? "LAMBDATEST_ACCESS_KEY" : System.getenv(
23+
"LT_ACCESS_KEY");
24+
String gridUrl = "@hub.lambdatest.com/wd/hub";
2325
try {
2426
this.driver = new RemoteWebDriver(new URL ("http://" + userName + ":" + accessKey + gridUrl), getChromeOptions());
25-
} catch (final MalformedURLException e) {
27+
} catch (MalformedURLException e) {
2628
System.out.println("Could not start the remote session on LambdaTest cloud grid");
2729
}
2830
this.driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(5));
2931
}
3032

3133
public ChromeOptions getChromeOptions() {
32-
final var browserOptions = new ChromeOptions();
34+
var browserOptions = new ChromeOptions();
3335
browserOptions.setPlatformName("Windows 10");
3436
browserOptions.setBrowserVersion("latest");
35-
final HashMap<String, Object> ltOptions = new HashMap<String, Object>();
37+
HashMap<String, Object> ltOptions = new HashMap<String, Object>();
3638
ltOptions.put("project", "LambdaTest e-commerce website automation");
3739
ltOptions.put("build", "LambdaTest e-commerceV1.0.0");
3840
ltOptions.put("name", "Homepage search product test");
@@ -46,7 +48,6 @@ public ChromeOptions getChromeOptions() {
4648

4749
@AfterTest
4850
public void tearDown() {
49-
5051
this.driver.executeScript("lambda-status=" + this.status);
5152
this.driver.quit();
5253
}

src/test/java/com/baeldung/LambdaTestEcommerceTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66

77
public class LambdaTestEcommerceTests extends BaseTest {
88
@Test
9-
public void testSearchProduct () {
10-
9+
public void whenUserSearchesForAProduct_ThenSearchResultsShouldBeDisplayed () {
1110
String productName = "iPhone";
1211

1312
driver.get ("https://ecommerce-playground.lambdatest.io/");

src/test/java/com/baeldung/pages/HomePage.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,22 @@
11
package com.baeldung.pages;
22

3-
import static org.testng.Assert.assertEquals;
4-
53
import org.openqa.selenium.By;
6-
import org.openqa.selenium.WebDriver;
74
import org.openqa.selenium.WebElement;
85
import org.openqa.selenium.remote.RemoteWebDriver;
96

107
public class HomePage {
118

12-
private RemoteWebDriver driver;
9+
private RemoteWebDriver driver;
1310

14-
public HomePage (final RemoteWebDriver driver) {
11+
public HomePage (RemoteWebDriver driver) {
1512
this.driver = driver;
1613
}
1714

18-
public SearchResultPage searchProduct(String productName) {
19-
WebElement searchBox = driver.findElement(By.name("search"));
20-
searchBox.sendKeys(productName);
21-
WebElement searchBtn = driver.findElement(By.cssSelector("button.type-text"));
22-
searchBtn.click();
15+
public SearchResultPage searchProduct (String productName) {
16+
WebElement searchBox = driver.findElement (By.name ("search"));
17+
searchBox.sendKeys (productName);
18+
WebElement searchBtn = driver.findElement (By.cssSelector ("button.type-text"));
19+
searchBtn.click ();
2320
return new SearchResultPage (driver);
2421
}
2522

src/test/java/com/baeldung/pages/SearchResultPage.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@ public class SearchResultPage {
99

1010
private RemoteWebDriver driver;
1111

12-
public SearchResultPage (final RemoteWebDriver driver) {
12+
public SearchResultPage (RemoteWebDriver driver) {
1313
this.driver = driver;
1414
}
1515

1616
public void verifySearchResultPageHeader (String productName) {
1717
String pageHeader = driver.findElement (By.tagName ("h1"))
1818
.getText ();
19-
2019
assertEquals (pageHeader, "Search - " + productName);
2120
}
2221
}

testng.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd">
33
<suite name="Selenium GitHub Actions demo">
4-
<test name="Searching a product from the HomePage of LambdaTest ECommerce website">
4+
<test name="Searching a product from the HomePage">
55
<classes>
66
<class name="com.baeldung.LambdaTestEcommerceTests">
77
<methods>

0 commit comments

Comments
 (0)