updated code for github actions (#4)

* updated the code as per baeldung guidelines

* updated env variable names

Author: mfaisalkhatri

src/test/java/com/baeldung/BaseTest.java

@@ -17,22 +17,24 @@ public class BaseTest {
 
     @BeforeTest
     public void setup() {
-        final String userName = System.getenv("LT_USERNAME") == null ? "LT_USERNAME" : System.getenv("LT_USERNAME");
-        final String accessKey = System.getenv("LT_ACCESS_KEY") == null ? "LT_ACCESS_KEY" : System.getenv("LT_ACCESS_KEY");
-        final String gridUrl = "@hub.lambdatest.com/wd/hub";
+        String userName = System.getenv("LAMBDATEST_USERNAME") == null ? "LAMBDATEST_USERNAME" : System.getenv(
+            "LT_USERNAME");
+        String accessKey = System.getenv("LAMBDATEST_ACCESS_KEY") == null ? "LAMBDATEST_ACCESS_KEY" : System.getenv(
+            "LT_ACCESS_KEY");
+        String gridUrl = "@hub.lambdatest.com/wd/hub";
         try {
             this.driver = new RemoteWebDriver(new URL ("http://" + userName + ":" + accessKey + gridUrl), getChromeOptions());
-        } catch (final MalformedURLException e) {
+        } catch (MalformedURLException e) {
             System.out.println("Could not start the remote session on LambdaTest cloud grid");
         }
         this.driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(5));
     }
 
     public ChromeOptions getChromeOptions() {
-        final var browserOptions = new ChromeOptions();
+        var browserOptions = new ChromeOptions();
         browserOptions.setPlatformName("Windows 10");
         browserOptions.setBrowserVersion("latest");
-        final HashMap<String, Object> ltOptions = new HashMap<String, Object>();
+        HashMap<String, Object> ltOptions = new HashMap<String, Object>();
         ltOptions.put("project", "LambdaTest e-commerce website automation");
         ltOptions.put("build", "LambdaTest e-commerceV1.0.0");
         ltOptions.put("name", "Homepage search product test");
@@ -46,7 +48,6 @@ public ChromeOptions getChromeOptions() {
 
     @AfterTest
     public void tearDown() {
-
         this.driver.executeScript("lambda-status=" + this.status);
         this.driver.quit();
     }

src/test/java/com/baeldung/LambdaTestEcommerceTests.java

@@ -6,8 +6,7 @@
 
 public class LambdaTestEcommerceTests extends BaseTest {
     @Test
-    public void testSearchProduct () {
-
+    public void whenUserSearchesForAProduct_ThenSearchResultsShouldBeDisplayed () {
         String productName = "iPhone";
 
         driver.get ("https://ecommerce-playground.lambdatest.io/");

src/test/java/com/baeldung/pages/HomePage.java

@@ -1,25 +1,22 @@
 package com.baeldung.pages;
 
-import static org.testng.Assert.assertEquals;
-
 import org.openqa.selenium.By;
-import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.remote.RemoteWebDriver;
 
 public class HomePage {
 
-    private RemoteWebDriver driver;
+    private  RemoteWebDriver driver;
 
-    public HomePage (final RemoteWebDriver driver) {
+    public HomePage (RemoteWebDriver driver) {
         this.driver = driver;
     }
 
-    public SearchResultPage searchProduct(String productName) {
-        WebElement searchBox = driver.findElement(By.name("search"));
-        searchBox.sendKeys(productName);
-        WebElement searchBtn = driver.findElement(By.cssSelector("button.type-text"));
-        searchBtn.click();
+    public SearchResultPage searchProduct (String productName) {
+        WebElement searchBox = driver.findElement (By.name ("search"));
+        searchBox.sendKeys (productName);
+        WebElement searchBtn = driver.findElement (By.cssSelector ("button.type-text"));
+        searchBtn.click ();
         return new SearchResultPage (driver);
     }
 

src/test/java/com/baeldung/pages/SearchResultPage.java

@@ -9,14 +9,13 @@ public class SearchResultPage {
 
     private RemoteWebDriver driver;
 
-    public SearchResultPage (final RemoteWebDriver driver) {
+    public SearchResultPage (RemoteWebDriver driver) {
         this.driver = driver;
     }
 
     public void verifySearchResultPageHeader (String productName) {
         String pageHeader = driver.findElement (By.tagName ("h1"))
             .getText ();
-
         assertEquals (pageHeader, "Search - " + productName);
     }
 }

testng.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd">
 <suite name="Selenium GitHub Actions demo">
-    <test name="Searching a product from the HomePage of LambdaTest ECommerce website">
+    <test name="Searching a product from the HomePage">
         <classes>
             <class name="com.baeldung.LambdaTestEcommerceTests">
                 <methods>