WaitingQueue: postpone feature

Author: BLeeEZ

Amperfy/Assets.xcassets/Contents.json

@@ -1,6 +1,6 @@
 {
   "info" : {
-    "version" : 1,
-    "author" : "xcode"
+    "author" : "xcode",
+    "version" : 1
   }
-}
+}

Amperfy/Assets.xcassets/main_insert.imageset/Contents.json Amperfy/Assets.xcassets/context_queue_append.imageset/Contents.json

@@ -9,7 +9,7 @@
       "scale" : "2x"
     },
     {
-      "filename" : "main_insert.png",
+      "filename" : "context_queue_append.png",
       "idiom" : "universal",
       "scale" : "3x"
     }

Amperfy/Assets.xcassets/context_queue_append.imageset/context_queue_append.png

@@ -9,7 +9,7 @@
       "scale" : "2x"
     },
     {
-      "filename" : "waiting_insert.png",
+      "filename" : "context_queue_insert.png",
       "idiom" : "universal",
       "scale" : "3x"
     }

Amperfy/Assets.xcassets/waiting_insert.imageset/Contents.json Amperfy/Assets.xcassets/context_queue_insert.imageset/Contents.json

@@ -9,7 +9,7 @@
       "scale" : "2x"
     },
     {
-      "filename" : "main_append.png",
+      "filename" : "user_queue_append.png",
       "idiom" : "universal",
       "scale" : "3x"
     }

Amperfy/Assets.xcassets/context_queue_insert.imageset/context_queue_insert.png

@@ -9,7 +9,7 @@
       "scale" : "2x"
     },
     {
-      "filename" : "waiting_append.png",
+      "filename" : "user_queue_insert.png",
       "idiom" : "universal",
       "scale" : "3x"
     }

Amperfy/Assets.xcassets/main_append.imageset/main_append.png

@@ -41,9 +41,9 @@ enum PlayerQueueType: Int, CaseIterable {
 
     var description : String {
         switch self {
-        case .prev: return "Previous in Main Queue"
+        case .prev: return "Previous"
         case .waitingQueue: return "Next in Waiting Queue"
-        case .next: return "Next in Main Queue"
+        case .next: return "Next"
         }
     }
 }

Amperfy/Assets.xcassets/main_insert.imageset/main_insert.png

@@ -35,7 +35,7 @@ typealias QueueSwipeCallback = (IndexPath, _ completionHandler: @escaping (_ pla
 
 extension BasicTableViewController {
     func createInsertNextQueueSwipeAction(indexPath: IndexPath, actionCallback: @escaping QueueSwipeCallback) -> UIContextualAction {
-        let action = UIContextualAction(style: .normal, title: "Insert into Next in Main Queue") { (action, view, completionHandler) in
+        let action = UIContextualAction(style: .normal, title: "Play Next") { (action, view, completionHandler) in
             let generator = UINotificationFeedbackGenerator()
             generator.notificationOccurred(.success)
             actionCallback(indexPath) { playables in
@@ -44,49 +44,21 @@ extension BasicTableViewController {
             completionHandler(true)
         }
         action.backgroundColor = .systemBlue
-        action.image = UIImage(named: "main_insert")?.invertedImage()
-        return action
-    }
-    
-    func createInsertWaitingQueueSwipeAction(indexPath: IndexPath, actionCallback: @escaping QueueSwipeCallback) -> UIContextualAction {
-        let action = UIContextualAction(style: .normal, title: "Insert into Next in Waiting Queue") { (action, view, completionHandler) in
-            let generator = UIImpactFeedbackGenerator(style: .light)
-            generator.impactOccurred()
-            actionCallback(indexPath) { playables in
-                self.appDelegate.player.insertFirstToWaitingQueue(playables: playables.filterCached(dependigOn: self.appDelegate.persistentStorage.settings.isOfflineMode))
-            }
-            completionHandler(true)
-        }
-        action.backgroundColor = .systemOrange
-        action.image = UIImage(named: "waiting_insert")?.invertedImage()
+        action.image = UIImage(named: "context_queue_insert")?.invertedImage()
         return action
     }
 
     func createAppendNextQueueSwipeAction(indexPath: IndexPath, actionCallback: @escaping QueueSwipeCallback) -> UIContextualAction {
-        let action = UIContextualAction(style: .normal, title: "Append to Next in Main Queue") { (action, view, completionHandler) in
+        let action = UIContextualAction(style: .normal, title: "Play Later") { (action, view, completionHandler) in
             let generator = UINotificationFeedbackGenerator()
             generator.notificationOccurred(.success)
             actionCallback(indexPath) { playables in
                 self.appDelegate.player.appendToNextInMainQueue(playables: playables.filterCached(dependigOn: self.appDelegate.persistentStorage.settings.isOfflineMode))
             }
             completionHandler(true)
         }
-        action.backgroundColor = .systemBlue
-        action.image = UIImage(named: "main_append")?.invertedImage()
-        return action
-    }
-    
-    func createAppendWaitingQueueSwipeAction(indexPath: IndexPath, actionCallback: @escaping QueueSwipeCallback) -> UIContextualAction {
-        let action = UIContextualAction(style: .normal, title: "Append to Next in Waiting Queue") { (action, view, completionHandler) in
-            let generator = UIImpactFeedbackGenerator(style: .light)
-            generator.impactOccurred()
-            actionCallback(indexPath) { playables in
-                self.appDelegate.player.appendToWaitingQueue(playables: playables.filterCached(dependigOn: self.appDelegate.persistentStorage.settings.isOfflineMode))
-            }
-            completionHandler(true)
-        }
         action.backgroundColor = .systemOrange
-        action.image = UIImage(named: "waiting_append")?.invertedImage()
+        action.image = UIImage(named: "context_queue_append")?.invertedImage()
         return action
     }
 }
@@ -120,18 +92,11 @@ class BasicTableViewController: UITableViewController {
         updateSearchResults(for: searchController)
     }
 
-    override func tableView(_ tableView: UITableView, leadingSwipeActionsConfigurationForRowAt indexPath: IndexPath) -> UISwipeActionsConfiguration? {
-        guard let swipeCB = swipeCallback else { return nil }
-        return UISwipeActionsConfiguration(actions: [
-            createInsertNextQueueSwipeAction(indexPath: indexPath, actionCallback: swipeCB),
-            createInsertWaitingQueueSwipeAction(indexPath: indexPath, actionCallback: swipeCB)
-        ])
-    }
     override func tableView(_ tableView: UITableView, trailingSwipeActionsConfigurationForRowAt indexPath: IndexPath) -> UISwipeActionsConfiguration? {
         guard let swipeCB = swipeCallback else { return nil }
         return UISwipeActionsConfiguration(actions: [
-            createAppendNextQueueSwipeAction(indexPath: indexPath, actionCallback: swipeCB),
-            createAppendWaitingQueueSwipeAction(indexPath: indexPath, actionCallback: swipeCB)
+            createInsertNextQueueSwipeAction(indexPath: indexPath, actionCallback: swipeCB),
+            createAppendNextQueueSwipeAction(indexPath: indexPath, actionCallback: swipeCB)
         ])
     }
 

Amperfy/Assets.xcassets/main_append.imageset/Contents.json Amperfy/Assets.xcassets/user_queue_append.imageset/Contents.json

@@ -80,31 +80,16 @@ class DirectoriesVC: BasicTableViewController {
             return 0.0
         }
     }
-    
-    override func tableView(_ tableView: UITableView, leadingSwipeActionsConfigurationForRowAt indexPath: IndexPath) -> UISwipeActionsConfiguration? {
-        guard indexPath.section == 1 else { return nil }
-        let adjustedIndexPath = IndexPath(row: indexPath.row , section: 0)
-        return UISwipeActionsConfiguration(actions: [
-            createInsertNextQueueSwipeAction(indexPath: adjustedIndexPath) { (indexPath, completionHandler) in
-                let song = self.songsFetchedResultsController.getWrappedEntity(at: indexPath)
-                completionHandler([song])
-            },
-            createInsertWaitingQueueSwipeAction(indexPath: adjustedIndexPath) { (indexPath, completionHandler) in
-                let song = self.songsFetchedResultsController.getWrappedEntity(at: indexPath)
-                completionHandler([song])
-            }
-        ])
-    }
 
     override func tableView(_ tableView: UITableView, trailingSwipeActionsConfigurationForRowAt indexPath: IndexPath) -> UISwipeActionsConfiguration? {
         guard indexPath.section == 1 else { return nil }
         let adjustedIndexPath = IndexPath(row: indexPath.row , section: 0)
         return UISwipeActionsConfiguration(actions: [
-            createAppendNextQueueSwipeAction(indexPath: adjustedIndexPath) { (indexPath, completionHandler) in
+            createInsertNextQueueSwipeAction(indexPath: adjustedIndexPath) { (indexPath, completionHandler) in
                 let song = self.songsFetchedResultsController.getWrappedEntity(at: indexPath)
                 completionHandler([song])
             },
-            createAppendWaitingQueueSwipeAction(indexPath: adjustedIndexPath) { (indexPath, completionHandler) in
+            createAppendNextQueueSwipeAction(indexPath: adjustedIndexPath) { (indexPath, completionHandler) in
                 let song = self.songsFetchedResultsController.getWrappedEntity(at: indexPath)
                 completionHandler([song])
             }

Amperfy/Assets.xcassets/user_queue_append.imageset/user_queue_append.png

@@ -247,26 +247,7 @@ class PopupPlayerVC: UIViewController, UITableViewDelegate, UITableViewDataSourc
 
     func refreshWaitingQueueSectionHeader() {
         let waitingQueueSectionView = sectionViews[1]
-        if player.waitingQueue.isEmpty {
-            waitingQueueSectionView.hide()
-        } else {
-            waitingQueueSectionView.display(type: .waitingQueue, buttonTitle: "Clear") {
-                self.clearWaitingQueue()
-            }
-        }
-    }
-    
-    func clearWaitingQueue() {
-        tableView.beginUpdates()
-        var indexPaths = [IndexPath]()
-        for i in 0...self.player.waitingQueue.count-1 {
-            indexPaths.append(IndexPath(row: i, section: 1))
-        }
-        tableView.deleteRows(at: indexPaths, with: .fade)
-        appDelegate.player.clearWaitingQueue()
-        tableView.endUpdates()
-        refreshWaitingQueueSectionHeader()
-        playerView?.refreshPlayer()
+        waitingQueueSectionView.hide()
     }
 
     // Override to support conditional rearranging of the table view.
@@ -307,11 +288,6 @@ class PopupPlayerVC: UIViewController, UITableViewDelegate, UITableViewDataSourc
             self.reloadData()
             self.playerView?.refreshPlayer()
         }))
-        if !player.waitingQueue.isEmpty {
-            alert.addAction(UIAlertAction(title: "Clear Waiting Queue", style: .default, handler: { _ in
-                self.clearWaitingQueue()
-            }))
-        }
         if appDelegate.persistentStorage.settings.isOnlineMode {
             alert.addAction(UIAlertAction(title: "Add all songs to playlist", style: .default, handler: { _ in
                 let selectPlaylistVC = PlaylistSelectorVC.instantiateFromAppStoryboard()