Add test for duplicate definition names

Author: mikeharder

src/test/incompatiblePropertiesTest.ts

@@ -3,6 +3,24 @@ import * as path from "path"
 import { OpenApiDiff } from ".."
 import { fileUrl } from "./fileUrl"
 
+test("should-allow-different-names", async () => {
+  const diff = new OpenApiDiff({})
+  const file = `src/test/specs/incompatible-properties/different-names.json`
+  const filePath = fileUrl(path.resolve(file))
+
+  // expected to pass
+  await diff.compare(file, file)
+})
+
+test("should-allow-duplicate-names", async () => {
+  const diff = new OpenApiDiff({})
+  const file = `src/test/specs/incompatible-properties/duplicate-names.json`
+  const filePath = fileUrl(path.resolve(file))
+
+  // expected to pass
+  await diff.compare(file, file)
+})
+
 // This test is part of regression test suite for https://github.com/Azure/azure-sdk-tools/issues/5981
 // Given a property with given type and name
 // When another property with the same name but an incompatible type is referenced

src/test/specs/incompatible-properties/common-types.json

@@ -0,0 +1,18 @@
+{
+  "swagger": "2.0",
+  "info": {
+    "title": "common-types",
+    "version": "1.0"
+  },
+  "paths": {},
+  "definitions": {
+    "Bar": {
+      "type": "object",
+      "properties": {
+        "p1": {
+          "type": "string"
+        }
+      }
+    }
+  }
+}

src/test/specs/incompatible-properties/different-names.json

@@ -0,0 +1,31 @@
+{
+  "swagger": "2.0",
+  "info": {
+    "title": "different-names",
+    "version": "1.0"
+  },
+  "paths": {},
+  "definitions": {
+    "Foo": {
+      "type": "object",
+      "properties": {
+        "p1": {
+          "type": "string"
+        }
+      },
+      "allOf": [
+        {
+          "$ref": "./common-types.json#/definitions/Bar"
+        }
+      ]
+    },
+    "Baz": {
+      "type": "object",
+      "properties": {
+        "p1": {
+          "type": "object"
+        }
+      }
+    }
+  }
+}

src/test/specs/incompatible-properties/duplicate-names.json

@@ -0,0 +1,31 @@
+{
+  "swagger": "2.0",
+  "info": {
+    "title": "duplicate-names",
+    "version": "1.0"
+  },
+  "paths": {},
+  "definitions": {
+    "Foo": {
+      "type": "object",
+      "properties": {
+        "p1": {
+          "type": "string"
+        }
+      },
+      "allOf": [
+        {
+          "$ref": "./common-types.json#/definitions/Bar"
+        }
+      ]
+    },
+    "Bar": {
+      "type": "object",
+      "properties": {
+        "p1": {
+          "type": "object"
+        }
+      }
+    }
+  }
+}