Revert "fix adding enum value & command line exception (#255)"

This reverts commit 000f1f7.

Author: mikeharder

openapi-diff/src/modeler/AutoRest.Swagger.Tests/SwaggerModelerCompareTests.cs

@@ -897,7 +897,7 @@ public void CommonParameterWithRef()
         public void XmsEnumModelAsString()
         {
             var messages = CompareSwagger("enum_as_string.json").ToArray();
-            Assert.Equal(2,messages.Where(m => m.Id == ComparisonMessages.AddedEnumValue.Id).ToList().Count());
+            Assert.Empty(messages.Where(m => m.Id == ComparisonMessages.AddedEnumValue.Id));
         }
 
         [Fact]

openapi-diff/src/modeler/AutoRest.Swagger/Model/SwaggerObject.cs

@@ -187,6 +187,7 @@ private void CompareEnums(ComparisonContext<ServiceDefinition> context, T prior)
             CompareXmsEnum(context,prior);
             bool relaxes = (prior.Enum != null && this.Enum == null);
             bool constrains = (prior.Enum == null && this.Enum != null);
+            bool isEnumModelAsString = (this.XmsEnum != null && this.XmsEnum.ModelAsString == true);
             if (!relaxes && !constrains)
             {
                 // It was enum and it is still enum i.e check for addition/removal
@@ -212,7 +213,9 @@ private void CompareEnums(ComparisonContext<ServiceDefinition> context, T prior)
                     IEnumerable<string> addedEnums = this.Enum.Except(prior.Enum);
                     if (addedEnums.Any())
                     {
-                        context.LogBreakingChange(ComparisonMessages.AddedEnumValue, String.Join(", ", addedEnums.ToList()));
+                        if (!isEnumModelAsString) {
+                            context.LogBreakingChange(ComparisonMessages.AddedEnumValue, String.Join(", ", addedEnums.ToList()));
+                        }
                     }
                 }
             }

src/lib/validators/openApiDiff.ts

@@ -82,10 +82,6 @@ const updateChangeProperties = (change: ChangeProperties, pf: ProcessedFile): Ch
   }
 }
 
-function escape(filePath: string) {
-  return `"${filePath}"`
-}
-
 /**
  * @class
  * Open API Diff class.
@@ -158,7 +154,7 @@ export class OpenApiDiff {
       const result = path.join(__dirname, "..", "..", "..", "node_modules", "autorest", "dist", "app.js")
       if (fs.existsSync(result)) {
         log.silly(`Found autoRest:${result} `)
-        return `node ${escape(result)}`
+        return `node ${result}`
       }
     }
 
@@ -167,7 +163,7 @@ export class OpenApiDiff {
       const result = path.join(__dirname, "..", "..", "..", "..", "..", "autorest", "dist", "app.js")
       if (fs.existsSync(result)) {
         log.silly(`Found autoRest:${result} `)
-        return `node ${escape(result)}`
+        return `node ${result}`
       }
     }
 
@@ -176,7 +172,7 @@ export class OpenApiDiff {
       const result = path.resolve("node_modules/.bin/autorest")
       if (fs.existsSync(result)) {
         log.silly(`Found autoRest:${result} `)
-        return escape(result)
+        return result
       }
     }
 
@@ -192,7 +188,7 @@ export class OpenApiDiff {
   public openApiDiffDllPath(): string {
     log.silly(`openApiDiffDllPath is being called`)
 
-    return escape(path.join(__dirname, "..", "..", "..", "dlls", "OpenApiDiff.dll"))
+    return path.join(__dirname, "..", "..", "..", "dlls", "OpenApiDiff.dll")
   }
 
   /**