-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tracing for client methods, transports #1881
Comments
We need to be able to define client-level fields. I opened a tracking issue for some options using the |
For trace levels, I propose the following after talking with @LarryOsterman:
I'm basing 3 through 5 partly on the fact that the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
As far as I know changing a trace level for a message isn't breaking. Thus we could start with |
This would significantly affect dev productivity as we debug our own tests. I'm not talking about devs using our crates, but us writing them. Stepping through async code when you're not sure exactly where the problem is exactly is incredibly unproductive. |
We need to implement tracing for all client methods and transports. PII needs to be sanitized and the safest option it so remove incidental printing of values e.g., derive or implement
Debug
and/orDisplay
sparingly.For now we are using the
tracing
crate and friends because it supports OpenTelemetry et. al. We could consider other options but these crates are fairly ubiquitous. Theopentelemetry
crate and friends are geared almost entirely to OpenTelemetry and would be good to understand how that is an advantage over something more generic.The text was updated successfully, but these errors were encountered: