Narrowly fix Test-Packages.ps1 and Analyze-Code.ps1 (#3106)

Author: danieljurek

eng/scripts/Analyze-Code.ps1

@@ -20,44 +20,99 @@ Analyzing code with
 "@
 
 if ($CheckWasm) {
-  Invoke-LoggedCommand "rustup target add wasm32-unknown-unknown"
+  # Temporary fix to exit immediately on failure. LogError should Write-Error
+  # instead
+  $command = "rustup target add wasm32-unknown-unknown"
+  Invoke-LoggedCommand $command
+  if ($LastExitCode) {
+    Write-Error "Failed to execute $command"
+  }
 }
 
 if ($Deny) {
-  Invoke-LoggedCommand "cargo install cargo-deny --locked"
+  # Temporary fix to exit immediately on failure. LogError should Write-Error
+  # instead
+  $command = "cargo install cargo-deny --locked"
+  Invoke-LoggedCommand $command
+  if ($LastExitCode) {
+    Write-Error "Failed to execute $command"
+  }
 }
 
-Invoke-LoggedCommand "cargo check --package azure_core --all-features --all-targets --keep-going"
+# Temporary fix to exit immediately on failure. LogError should Write-Error
+# instead
+$command = "cargo check --package azure_core --all-features --all-targets --keep-going"
+Invoke-LoggedCommand $command
+if ($LastExitCode) {
+  Write-Error "Failed to execute $command"
+}
 
-Invoke-LoggedCommand "cargo fmt --all -- --check"
+# Temporary fix to exit immediately on failure. LogError should Write-Error
+# instead
+$command = "cargo fmt --all -- --check"
+Invoke-LoggedCommand $command
+if ($LastExitCode) {
+  Write-Error "Failed to execute $command"
+}
 
-Invoke-LoggedCommand "cargo clippy --workspace --all-features --all-targets --keep-going --no-deps"
+# Temporary fix to exit immediately on failure. LogError should Write-Error
+# instead
+$command = "cargo clippy --workspace --all-features --all-targets --keep-going --no-deps"
+Invoke-LoggedCommand $command
+if ($LastExitCode) {
+  Write-Error "Failed to execute $command"
+}
 
 if ($CheckWasm) {
   # Save the original RUSTFLAGS to restore later
   $OriginalRustFlags = $env:RUSTFLAGS
   # This is needed to ensure that the `getrandom` crate uses the `wasm_js` backend
   $env:RUSTFLAGS = ${env:RUSTFLAGS} + ' --cfg getrandom_backend="wasm_js"'
 
-  Invoke-LoggedCommand "cargo clippy --target=wasm32-unknown-unknown --workspace --keep-going --no-deps"
+  # Temporary fix to exit immediately on failure. LogError should Write-Error
+  # instead
+  $command = "cargo clippy --target=wasm32-unknown-unknown --workspace --keep-going --no-deps"
+  Invoke-LoggedCommand $command
+  if ($LastExitCode) {
+    Write-Error "Failed to execute $command"
+  }
 
   # Restore the original RUSTFLAGS, since the getrandom config option can only be set for wasm32-unknown-unknown builds.
   $env:RUSTFLAGS = $OriginalRustFlags
 }
 
 if ($Deny) {
-  Invoke-LoggedCommand "cargo deny --all-features check"
+  # Temporary fix to exit immediately on failure. LogError should Write-Error
+  # instead
+  $command = "cargo deny --all-features check"
+  Invoke-LoggedCommand $command
+  if ($LastExitCode) {
+    Write-Error "Failed to execute $command"
+  }
 }
 
-Invoke-LoggedCommand "cargo doc --workspace --no-deps --all-features"
+# Temporary fix to exit immediately on failure. LogError should Write-Error
+# instead
+$command = "cargo doc --workspace --no-deps --all-features"
+Invoke-LoggedCommand $command
+if ($LastExitCode) {
+  Write-Error "Failed to execute $command"
+}
 
 # Verify package dependencies
 $verifyDependenciesScript = Join-Path $RepoRoot 'eng' 'scripts' 'verify-dependencies.rs' -Resolve
 
 if (!$SkipPackageAnalysis) {
   if (!(Test-Path $PackageInfoDirectory)) {
     Write-Host "Analyzing workspace`n"
-    return Invoke-LoggedCommand "&$verifyDependenciesScript $RepoRoot/Cargo.toml"
+    # Temporary fix to exit immediately on failure. LogError should Write-Error
+    # instead
+    $command = "&$verifyDependenciesScript $RepoRoot/Cargo.toml"
+    $result = Invoke-LoggedCommand $command
+    if ($LastExitCode) {
+      Write-Error "Failed to execute $command"
+    }
+    return $result
   }
 
   $packagesToTest = Get-ChildItem $PackageInfoDirectory -Filter "*.json" -Recurse
@@ -66,6 +121,12 @@ if (!$SkipPackageAnalysis) {
 
   foreach ($package in $packagesToTest) {
     Write-Host "Analyzing package '$($package.Name)' in directory '$($package.DirectoryPath)'`n"
-    Invoke-LoggedCommand "&$verifyDependenciesScript $($package.DirectoryPath)/Cargo.toml"
+    # Temporary fix to exit immediately on failure. LogError should Write-Error
+    # instead
+    $command = "&$verifyDependenciesScript $($package.DirectoryPath)/Cargo.toml"
+    Invoke-LoggedCommand $command
+    if ($LastExitCode) {
+      Write-Error "Failed to execute $command"
+    }
   }
 }

eng/scripts/Test-Packages.ps1

@@ -56,13 +56,31 @@ foreach ($package in $packagesToTest) {
 
     Write-Host "`n`nTesting package: '$($package.Name)'`n"
 
-    Invoke-LoggedCommand "cargo build --keep-going" -GroupOutput
+    # Temporary fix to exit immediately on failure. LogError should Write-Error
+    # instead
+    $command = "cargo build --keep-going"
+    Invoke-LoggedCommand $command -GroupOutput
+    if ($LastExitCode) { 
+      Write-Error "Failed to execute $command"
+    }
     Write-Host "`n`n"
 
-    Invoke-LoggedCommand "cargo test --doc --no-fail-fast" -GroupOutput
+    # Temporary fix to exit immediately on failure. LogError should Write-Error
+    # instead
+    $command = "cargo test --doc --no-fail-fast" 
+    Invoke-LoggedCommand $command -GroupOutput
+    if ($LastExitCode) { 
+      Write-Error "Failed to execute $command"
+    }
     Write-Host "`n`n"
 
-    Invoke-LoggedCommand "cargo test --all-targets --no-fail-fast" -GroupOutput
+    # Temporary fix to exit immediately on failure. LogError should Write-Error
+    # instead
+    $command = "cargo test --all-targets --no-fail-fast" 
+    Invoke-LoggedCommand $command -GroupOutput
+    if ($LastExitCode) {
+      Write-Error "Failed to execute $command"
+    }
     Write-Host "`n`n"
 
     $cleanupScript = Join-Path $packageDirectory "Test-Cleanup.ps1"