[AutoPR azure-resourcemanager-msi]-generated-from-SDK Generation - Java-6569269#49835
Merged
weidongxu-microsoft merged 6 commits intoJul 16, 2026
Merged
Conversation
…Identity/ManagedIdentity/tspconfig.yaml', API Version: 2024-11-30, SDK Release Type: stable, and CommitSHA: '7d2fd18ef8d50e448c2a9ec19727d5fec37bccde' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6569269 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Fixes #49836. Add isolationScope() getter and withIsolationScope(IsolationScope) fluent setter to Identity create/update flows, wiring the value into IdentityInner so it is serialized in the request body. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d6cfc2c-117c-4e61-b9b1-dbde1c3b8601
Adds canCreateIdentityWithIsolationScope test to MSIIdentityManagementTests and updates assets.json to the recorded session tag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d6cfc2c-117c-4e61-b9b1-dbde1c3b8601
Extend canCreateIdentityWithIsolationScope to update the identity's isolationScope from Regional to None and verify the change round-trips. Update assets.json to the re-recorded session tag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d6cfc2c-117c-4e61-b9b1-dbde1c3b8601
Member
|
fix #49836 |
Add default implementations throwing UnsupportedOperationException for the newly added isolationScope() and withIsolationScope(...) methods to avoid breaking external implementers of the Identity interface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d6cfc2c-117c-4e61-b9b1-dbde1c3b8601
weidongxu-microsoft
marked this pull request as ready for review
July 16, 2026 03:12
weidongxu-microsoft
requested review from
a team,
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
July 16, 2026 03:12
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates azure-resourcemanager-msi to a new stable, TypeSpec-generated API surface targeting Microsoft.ManagedIdentity 2024-11-30, aligning tests/samples/metadata and preparing the package for release.
Changes:
- Moves the management-plane client to API version 2024-11-30 and bumps the package to 2.54.0 (stable), including metadata/versioning updates.
- Adds fluent support for configuring
IsolationScopeonIdentity(create + update) and adds a management test covering round-tripping. - Removes previously generated preview-only model surface (e.g.,
AssignmentRestrictions,ClaimsMatchingExpression) and updates generated samples accordingly.
Reviewed changes
Copilot reviewed 18 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/msi/azure-resourcemanager-msi/tsp-location.yaml | Removes the TypeSpec spec pin file for this package. |
| sdk/msi/azure-resourcemanager-msi/src/test/java/com/azure/resourcemanager/msi/MSIIdentityManagementTests.java | Adds a live test for create/get/update of IsolationScope. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesUpdateSamples.java | Updates sample to 2024-11-30 and removes preview-only AssignmentRestrictions usage. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesListSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesListByResourceGroupSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesGetByResourceGroupSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesDeleteSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesCreateOrUpdateSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/SystemAssignedIdentitiesGetByScopeSamples.java | Updates the sample, but currently has mismatched method name/JavaDoc vs the operation being called. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/OperationsListSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsListSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsGetSamples.java | Removes flexible-FIC preview sample and updates to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsDeleteSamples.java | Updates x-ms-original-file to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsCreateOrUpdateSamples.java | Removes flexible-FIC preview sample and updates to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/main/resources/META-INF/azure-resourcemanager-msi_metadata.json | Updates apiVersion to 2024-11-30 and refreshes generator metadata fields. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/IdentityUpdate.java | Removes assignmentRestrictions from the update model surface. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/Identity.java | Adds fluent isolationScope() and create/update stage hooks for withIsolationScope(...). |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/ClaimsMatchingExpression.java | Deletes the preview-only model type. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/AssignmentRestrictions.java | Deletes the preview-only model type. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/ManagedServiceIdentityClientImpl.java | Updates the hard-coded apiVersion string to 2024-11-30. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/IdentityImpl.java | Wires isolationScope() + fluent withIsolationScope(...) to the inner model. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/UserAssignedIdentityProperties.java | Removes assignmentRestrictions serialization and validation. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/IdentityInner.java | Removes assignmentRestrictions passthrough accessors. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/FederatedIdentityCredentialProperties.java | Removes claimsMatchingExpression support and makes subject required in validation. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/FederatedIdentityCredentialInner.java | Removes claimsMatchingExpression passthrough accessors. |
| sdk/msi/azure-resourcemanager-msi/README.md | Updates the dependency snippet to version 2.54.0. |
| sdk/msi/azure-resourcemanager-msi/pom.xml | Bumps to 2.54.0 and enables Revapi checks (revapi.skip=false). |
| sdk/msi/azure-resourcemanager-msi/CHANGELOG.md | Adds 2.54.0 release notes (currently includes misleading “Breaking Changes” entries). |
| sdk/msi/azure-resourcemanager-msi/assets.json | Updates the assets tag reference. |
| eng/versioning/version_client.txt | Updates the service version entry to 2.54.0. |
XiaofeiCao
approved these changes
Jul 16, 2026
weidongxu-microsoft
deleted the
sdkauto/azure-resourcemanager-msi-6569269
branch
July 16, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/msi/resource-manager/Microsoft.ManagedIdentity/ManagedIdentity/tspconfig.yaml', API Version: 2024-11-30, SDK Release Type: stable, and CommitSHA: '7d2fd18ef8d50e448c2a9ec19727d5fec37bccde' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6569269 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.