Skip to content

Storage - STG104 NFS List V2 Files and Directories#49246

Merged
ibrandes merged 21 commits into
Azure:feature/storage/stg104basefrom
browndav-msft:stg104/nfsListv2
Jul 2, 2026
Merged

Storage - STG104 NFS List V2 Files and Directories#49246
ibrandes merged 21 commits into
Azure:feature/storage/stg104basefrom
browndav-msft:stg104/nfsListv2

Conversation

@browndav-msft

@browndav-msft browndav-msft commented May 22, 2026 •
edited by ibrandes
Loading

Copy link
Copy Markdown
Member

Summary

Adds support for XNFS ListFilesV2 REST API enhancements to return extended metadata for NFS files directly from the list response.

Changes

  • Enables extended properties for NFS files in ListFiles (timestamps, ETag, UID/GID, mode, link count, NFS attributes, etc.)
  • Ensures up-to-date Content-Length and timestamps by reconciling namespace and blob data
  • Introduces consistency tracking (stateful/stateless flags) to determine when data must be fetched from blob storage
  • Adds support for special file types (symlink, device files, FIFO, socket) in responses
  • Implements batched blob fetches for files with stale metadata
  • Introduces backfill mechanism to update existing namespace rows and reduce future lookup cost

Impact

  • Eliminates need for per-file GET calls to retrieve metadata
  • Improves performance and scalability for scenarios like backup validation
  • Aligns NFS behavior with SMB ListFilesV2 capabilities

@github-actions github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label May 22, 2026
@browndav-msft
browndav-msft changed the base branch from main to feature/storage/stg104base May 22, 2026 16:09
@ibrandes ibrandes changed the title Stg104/nfs listv2 Storage - STG104 NFS List V2 Files and Directories Jun 4, 2026
@ibrandes
ibrandes requested a review from Copilot June 4, 2026 17:52
Copilot AI reviewed Jun 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot stopped reviewing on behalf of ibrandes due to an error June 4, 2026 18:53
Copilot had to stop work due to a timeout.
@ibrandes
ibrandes requested a review from Copilot June 4, 2026 19:28
Copilot AI reviewed Jun 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 10 comments.

Comment thread sdk/storage/azure-storage-file-share/swagger/README.md
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryClient.java
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryClient.java Outdated
Comment thread ...re-storage-file-share/src/test/java/com/azure/storage/file/share/DirectoryAsyncApiTests.java Outdated
Comment thread .../src/main/java/com/azure/storage/file/share/options/ShareListFilesAndDirectoriesOptions.java
Comment thread .../src/main/java/com/azure/storage/file/share/options/ShareListFilesAndDirectoriesOptions.java
Comment thread .../src/main/java/com/azure/storage/file/share/options/ShareListFilesAndDirectoriesOptions.java
Comment thread .../src/main/java/com/azure/storage/file/share/options/ShareListFilesAndDirectoriesOptions.java
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java Outdated
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java
ibrandes
ibrandes reviewed Jun 17, 2026
View reviewed changes
Comment thread ...storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryAsyncClient.java Outdated
Comment thread ...ge/azure-storage-file-share/src/test/resources/testfiles/ListFilesAndDirectoriesResponse.xml
@ibrandes
ibrandes requested a review from Copilot June 17, 2026 05:09
Copilot AI reviewed Jun 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Comment thread sdk/storage/azure-storage-file-share/swagger/README.md
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryClient.java Outdated
@browndav-msft

browndav-msft commented Jun 28, 2026

Copy link
Copy Markdown
Member Author

@ibrandes There are other failures, but there are for things that we did not touch in this branch.

ibrandes
ibrandes reviewed Jun 28, 2026
View reviewed changes
Comment thread ...e-file-share/src/main/java/com/azure/storage/file/share/implementation/util/ModelHelper.java
Comment thread ...e-file-share/src/main/java/com/azure/storage/file/share/implementation/util/ModelHelper.java Outdated
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java
Comment thread ...storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryAsyncClient.java Outdated
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryClient.java Outdated
@ibrandes
ibrandes requested a review from Copilot June 28, 2026 17:05
Copilot AI reviewed Jun 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.

Comment thread sdk/storage/azure-storage-file-share/swagger/README.md
Comment thread ...com/azure/storage/file/share/implementation/accesshelpers/ShareFileItemConstructorProxy.java
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java Outdated
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java Outdated
Comment thread ...zure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileItem.java Outdated
@browndav-msft
add com.azure.storage.common.implementation.contentvalidation.Content…
cf40478 
…ValidationModeResolver export to module-info.java to fix failing test: OAuthCopySourceTests.copyFromURLWithOAuthSourceInvalidCredential
@ibrandes
ibrandes self-requested a review July 2, 2026 20:13
@ibrandes
ibrandes marked this pull request as ready for review July 2, 2026 20:16
@ibrandes
ibrandes merged commit b75c5ff into Azure:feature/storage/stg104base Jul 2, 2026
8 of 13 checks passed
browndav-msft added a commit that referenced this pull request Jul 13, 2026
@browndav-msft
Revert "Storage - STG104 NFS List V2 Files and Directories (#49246)" (#…
137c8fa 
…49770)

* Revert "Storage - STG104 NFS List V2 Files and Directories (#49246)"

This reverts commit b75c5ff.

* add missing deps in ShareDirectory sync and async clients

* remove generated code from NfsFileType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@ibrandes ibrandes ibrandes approved these changes
@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner
@gunjansingh-msft gunjansingh-msft Awaiting requested review from gunjansingh-msft gunjansingh-msft is a code owner
@kyleknap kyleknap Awaiting requested review from kyleknap kyleknap is a code owner
@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

Assignees

No one assigned

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@browndav-msft @ibrandes