Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15062#3442

Closed
azure-sdk wants to merge 3 commits into
mainfrom
sync-eng/common-squad/15049-sync-shared-skills-15062
Closed

Sync eng/common directory with azure-sdk-tools for PR 15062#3442
azure-sdk wants to merge 3 commits into
mainfrom
sync-eng/common-squad/15049-sync-shared-skills-15062

Conversation

@azure-sdk

Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15062 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner April 10, 2026 18:51
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Apr 10, 2026
ronniegeraghty and others added 3 commits April 14, 2026 23:42
Rename 5 shared skills to use the azsdk-common- prefix so the
sync-.github.yml pipeline can pattern-match and distribute them to all
subscribed Azure SDK language repos.

Renames:
  generate-sdk-locally → azsdk-common-generate-sdk-locally
  apiview-feedback-resolution → azsdk-common-apiview-feedback-resolution
  pipeline-troubleshooting → azsdk-common-pipeline-troubleshooting
  prepare-release-plan → azsdk-common-prepare-release-plan
  sdk-release → azsdk-common-sdk-release

Updated:
- SKILL.md name: fields in all 5 skills
- All eval.yaml and trigger_tests.yaml skill/name references
- .github/skills/README.md links and naming convention docs
- sensei SKILL.md example reference
- 8 instruction files in eng/common/instructions/azsdk-tools/ with
  Related Skill cross-references pointing to new skill paths
- copilot/sdk-release.instructions.md with skill cross-reference

Relates to #15049

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changes based on semantic analysis of skill/instruction purpose alignment:

- check-package-validation: Remove incorrect related_skill reference to
  generate-sdk-locally. Validation is a narrow sub-step; pointing users at
  the full generation workflow is misleading. Added redundancy note instead.

- typespec-to-sdk: Add missing pipeline-troubleshooting and
  apiview-feedback-resolution skills to the orchestrator. This is the
  entry point where users discover their options after TypeSpec work is
  merged — all journey skills should be discoverable here. Also added
  inline references at the exact workflow steps where those skills apply.

- create-release-plan: Add missing frontmatter with related_skill
  (had blockquote but no structured metadata).

- copilot/sdk-release: Add missing frontmatter with related_skill
  (had blockquote but no structured metadata).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Delete 7 instruction files whose content is now fully covered by skills:
- local-sdk-workflow.instructions.md → azsdk-common-generate-sdk-locally
- create-release-plan.instructions.md → azsdk-common-prepare-release-plan
- sdk-details-in-release-plan.instructions.md → azsdk-common-prepare-release-plan
- verify-namespace-approval.instructions.md → azsdk-common-prepare-release-plan
- check-package-readiness.instructions.md → azsdk-common-sdk-release
- check-package-validation.instructions.md → azsdk-common-generate-sdk-locally
- copilot/sdk-release.instructions.md → azsdk-common-sdk-release

Skills updated with all unique details from instruction files:
- generate-sdk-locally: added commit checkpoints, language selection,
  config file identification, SDK project path, metadata update tools
- prepare-release-plan: added critical LLM instructions (NextSteps field),
  Release Planner Tool link, package name extraction rules per language,
  valid/invalid examples table, JSON structure, namespace approval flow
- sdk-release: added readiness check details, interaction flow pattern,
  do-not-ask-for-PR/plan guard, case-sensitive language note

typespec-to-sdk orchestrator updated to reference skills directly.
Removed all related_skill frontmatter and blockquotes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-sdk azure-sdk force-pushed the sync-eng/common-squad/15049-sync-shared-skills-15062 branch from 625d733 to c212fa0 Compare April 14, 2026 23:42
@ronniegeraghty

Copy link
Copy Markdown
Member

Closing — source PR Azure/azure-sdk-tools#15062 was closed and superseded by Azure/azure-sdk-tools#15210. New sync PRs will be generated from #15210 when it lands.

@azure-sdk azure-sdk deleted the sync-eng/common-squad/15049-sync-shared-skills-15062 branch April 26, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants