fix: Handle comma-separated values in x-forwarded-port header #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucadelauw
requested review from
gavin-aguiar,
hallvictoria and
vrdmr
as code owners
Author
|
@microsoft-github-policy-service agree |
Author
|
Can this please be looked at since it's quite a blocking issue. This is a fairly straightforward fix |
Contributor
|
Hi @lucadelauw, thanks for this. Our next beta release (1.25.0b2) has a lot of changes currently, but we can look at taking this in the beta release after (1.25.0b3). ETA for b3 release will be ~end of this week to unblock this scenario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Azure Functions applications are deployed behind proxies or load balancers (such as Azure Application Gateway), the 'x-forwarded-port' header may contain multiple comma-separated port values (e.g., "443,8080,433"). The current implementation attempts to convert the entire string to an integer, which causes an error and subsequent function crash.
My fix extracts the first port value from this header and also strips whitespaces. Also included new tests for these
see: Azure/azure-functions-python-worker#1768