Skip to content

Commit 75a1a79

Browse files
authored
[Linter] Fix minor display issue in azdev linter (#259)
* fix display issue * bump version and add history * refract * format output
1 parent d054b76 commit 75a1a79

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
33
Release History
44
===============
5+
0.1.28
6+
++++++
7+
* [Linter] Fix minor display issue in `azdev linter`.
8+
59
0.1.27
610
++++++
711
* [Linter] "Show" command should use `show_command` or `custom_show_command`.

azdev/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# license information.
55
# -----------------------------------------------------------------------------
66

7-
__VERSION__ = '0.1.27'
7+
__VERSION__ = '0.1.28'

azdev/operations/linter/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,7 @@ def run_linter(modules=None, rule_types=None, rules=None, ci_exclusions=None,
160160
run_commands=not rule_types or 'commands' in rule_types,
161161
run_command_groups=not rule_types or 'command_groups' in rule_types,
162162
run_help_files_entries=not rule_types or 'help_entries' in rule_types)
163-
logger.info(os.linesep)
164-
logger.info('Run custom pylint rules.')
163+
display(os.linesep + 'Run custom pylint rules.')
165164
exit_code += pylint_rules(selected_modules)
166165
sys.exit(exit_code)
167166

@@ -178,9 +177,10 @@ def pylint_rules(selected_modules):
178177
pylint_result = run_pylint(selected_modules, env=my_env, checkers=checkers, disable_all=True, enable=enable)
179178
if pylint_result and not pylint_result.error:
180179
display(os.linesep + 'No violations found for custom pylint rules.')
180+
display('Linter: PASSED\n')
181181
if pylint_result and pylint_result.error:
182-
logger.info(pylint_result.error.output.decode('utf-8'))
183-
logger.info('Linter: FAILED\n')
182+
display(pylint_result.error.output.decode('utf-8'))
183+
display('Linter: FAILED\n')
184184
return pylint_result.exit_code
185185

186186

0 commit comments

Comments
 (0)