eng, fix submodule ci (#3159)

* fail if commit id not found

* use PR ID as input

* rename to ci-submodule-pull-request.yaml

Author: weidongxu-microsoft

eng/pipelines/ci-submodule-commit.yaml

@@ -0,0 +1,18 @@
+trigger: none
+pr: none
+
+parameters:
+- name: SubmodulePullRequestId
+  displayName: 'Pull Request ID of the Submodule'
+  type: string
+
+jobs:
+- template: /eng/pipelines/jobs/build-autorest.yml
+  parameters:
+    SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}
+- template: /eng/pipelines/jobs/build-autorest-mgmt.yml
+  parameters:
+    SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}
+- template: /eng/pipelines/jobs/build-typespec.yml
+  parameters:
+    SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}

eng/pipelines/ci-submodule-pull-request.yaml

@@ -1,5 +1,5 @@
 parameters:
-- name: SubmoduleCommit
+- name: SubmodulePullRequestId
   type: string
   default: ''
 
@@ -21,10 +21,10 @@ jobs:
   - checkout: self
     submodules: true
 
-  - ${{ if ne(parameters.SubmoduleCommit, '') }} :
+  - ${{ if ne(parameters.SubmodulePullRequestId, '') }} :
     - template: /eng/pipelines/steps/update-submodule-commit.yml
       parameters:
-        SubmoduleCommit: ${{ parameters.SubmoduleCommit }}
+        SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}
 
   - script: |
       git checkout .

eng/pipelines/jobs/build-autorest-mgmt.yml

@@ -1,5 +1,5 @@
 parameters:
-- name: SubmoduleCommit
+- name: SubmodulePullRequestId
   type: string
   default: ''
 
@@ -21,10 +21,10 @@ jobs:
   - checkout: self
     submodules: true
 
-  - ${{ if ne(parameters.SubmoduleCommit, '') }} :
+  - ${{ if ne(parameters.SubmodulePullRequestId, '') }} :
     - template: /eng/pipelines/steps/update-submodule-commit.yml
       parameters:
-        SubmoduleCommit: ${{ parameters.SubmoduleCommit }}
+        SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}
 
   - script: |
       git checkout .

eng/pipelines/jobs/build-autorest.yml

@@ -1,5 +1,5 @@
 parameters:
-- name: SubmoduleCommit
+- name: SubmodulePullRequestId
   type: string
   default: ''
 - name: UploadSpectorReport
@@ -23,4 +23,4 @@ jobs:
   steps:
   - template: /eng/pipelines/steps/build-typespec.yml
     parameters:
-      SubmoduleCommit: ${{ parameters.SubmoduleCommit }}
+      SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}

eng/pipelines/jobs/build-typespec.yml

@@ -2,10 +2,10 @@ steps:
 - checkout: self
   submodules: true
 
-- ${{ if ne(parameters.SubmoduleCommit, '') }} :
+- ${{ if ne(parameters.SubmodulePullRequestId, '') }} :
   - template: /eng/pipelines/steps/update-submodule-commit.yml
     parameters:
-      SubmoduleCommit: ${{ parameters.SubmoduleCommit }}
+      SubmodulePullRequestId: ${{ parameters.SubmodulePullRequestId }}
 
 - task: NodeTool@0
   displayName: 'Install Node.js $(NodeVersion)'

eng/pipelines/steps/build-typespec.yml

@@ -1,13 +1,14 @@
 parameters:
-- name: SubmoduleCommit
+- name: SubmodulePullRequestId
   type: string
 
 steps:
 - script: |
+    set -e
     cd core
-    git pull --unshallow
-    git checkout ${{ parameters.SubmoduleCommit }}
+    git fetch origin pull/${{ parameters.SubmodulePullRequestId }}/head:pull_${{ parameters.SubmodulePullRequestId }}_head
+    git checkout pull_${{ parameters.SubmodulePullRequestId }}_head
     cd ..
     git add core
-    git commit -m 'update core to commit ${{ parameters.SubmoduleCommit }}'
-  displayName: 'Update Submodule to Commit ${{ parameters.SubmoduleCommit }}'
+    git commit -m 'update core to head of PR ${{ parameters.SubmodulePullRequestId }}'
+  displayName: 'Update Submodule to Pull Request ID ${{ parameters.SubmodulePullRequestId }}'