You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up work from review feedback on #183 (feat: add JSON schemas and Copilot prompts for filter/override configuration). The PR was merged/advanced, but several reviewer comments call for refinements to the Copilot prompt templates and related docs. This issue tracks addressing them.
Items to address
Documentation
Link to prompt files for users who didn't run apiops init — In docs/guides/environment-overrides.md (~line 28), now that the prompt files are separated, link to them so users who didn't start with apiops init know where to find the prompt to use.
Remove artificial word wrapping in src/templates/copilot/configure-filter-prompt.md (~line 23) — reformat more naturally and let the containing editor handle wrapping.
Validate user-provided input in src/templates/copilot/configure-overrides-prompt.md (~line 143) — consider validating what the user tells us, only if the gh CLI is available.
Auto-query instead of asking the user in src/templates/copilot/configure-overrides-prompt.md (~line 141) — rather than asking the user, check whether the gh CLI is installed, logged in, and connected to the repo, and if so query for the value automatically (asking the user for permission to check automatically first).
Reduce questions by inspecting the pipeline in src/templates/copilot/configure-overrides-prompt.md (~line 159) — instead of asking the user for many things, have Copilot look at the pipeline.
Confirm YAML matches the schema in src/templates/copilot/configure-overrides-prompt.md (~line 276) — have Copilot confirm the generated YAML file contents match the schema.
Reconsider the show step in src/templates/copilot/configure-overrides-prompt.md (~line 279) — "show" is hard since the user could be in the VS Code terminal, GitHub Copilot, the GitHub agent tab, or elsewhere. Investigate what Copilot does here; if the instruction is sufficient, keep it. Otherwise consider an alternative, e.g. instructing the user to review the files for correctness before checking them in, and ending the prompt there.
Prefix prompt names with apiops in src/templates/copilot/configure-overrides-prompt.md (and the other prompts) — consider prefacing all prompt names with apiops to match the CLI and make them easier to find, e.g. /apiops-configure-overrides.
Summary
Follow-up work from review feedback on #183 (feat: add JSON schemas and Copilot prompts for filter/override configuration). The PR was merged/advanced, but several reviewer comments call for refinements to the Copilot prompt templates and related docs. This issue tracks addressing them.
Items to address
Documentation
apiops init— Indocs/guides/environment-overrides.md(~line 28), now that the prompt files are separated, link to them so users who didn't start withapiops initknow where to find the prompt to use.Prompt formatting
src/templates/copilot/configure-filter-prompt.md(~line 23) — reformat more naturally and let the containing editor handle wrapping.src/templates/copilot/configure-overrides-prompt.md(~line 23) — same as above; let the editor handle word wrap.Prompt behavior / UX
src/templates/copilot/configure-overrides-prompt.md(~line 143) — consider validating what the user tells us, only if theghCLI is available.src/templates/copilot/configure-overrides-prompt.md(~line 141) — rather than asking the user, check whether theghCLI is installed, logged in, and connected to the repo, and if so query for the value automatically (asking the user for permission to check automatically first).src/templates/copilot/configure-overrides-prompt.md(~line 159) — instead of asking the user for many things, have Copilot look at the pipeline.src/templates/copilot/configure-overrides-prompt.md(~line 276) — have Copilot confirm the generated YAML file contents match the schema.showstep insrc/templates/copilot/configure-overrides-prompt.md(~line 279) — "show" is hard since the user could be in the VS Code terminal, GitHub Copilot, the GitHub agent tab, or elsewhere. Investigate what Copilot does here; if the instruction is sufficient, keep it. Otherwise consider an alternative, e.g. instructing the user to review the files for correctness before checking them in, and ending the prompt there.Prompt naming
apiopsinsrc/templates/copilot/configure-overrides-prompt.md(and the other prompts) — consider prefacing all prompt names withapiopsto match the CLI and make them easier to find, e.g./apiops-configure-overrides.Related