revert product subscription cleanup

Author: EMaher

src/services/product-publisher.ts

@@ -99,50 +99,9 @@ async function cleanupAutoCreatedProductResources(
   context: ApimServiceContext,
   productDescriptor: ResourceDescriptor
 ): Promise<void> {
-  await cleanupProductSubscriptions(client, context, productDescriptor);
   await cleanupProductGroups(client, context, productDescriptor);
 }
 
-async function cleanupProductSubscriptions(
-  client: IApimClient,
-  context: ApimServiceContext,
-  productDescriptor: ResourceDescriptor
-): Promise<void> {
-  const productName = getNamePart(productDescriptor.nameParts, 0);
-  const expectedScopeSuffix = `/products/${productName}`;
-
-  let deleted = 0;
-
-  for await (const subscription of client.listResources(context, ResourceType.Subscription)) {
-    const descriptor = parseSubscriptionDescriptor(subscription, context);
-    if (!descriptor || descriptor.workspace !== productDescriptor.workspace) {
-      continue;
-    }
-
-    const props = subscription.properties as Record<string, unknown> | undefined;
-    const scope = typeof props?.scope === 'string' ? props.scope : '';
-    if (!scope.endsWith(expectedScopeSuffix)) {
-      continue;
-    }
-
-    try {
-      const removed = await client.deleteResource(context, descriptor);
-      if (removed) {
-        deleted++;
-        logger.debug(`Deleted APIM auto-created product subscription: ${descriptor.nameParts[0]}`);
-      }
-    } catch (error) {
-      logger.warn(
-        `Failed to delete APIM auto-created product subscription ${descriptor.nameParts[0]}: ${String(error)}`
-      );
-    }
-  }
-
-  if (deleted > 0) {
-    logger.info(`Deleted ${deleted} auto-created subscription(s) for product: ${productName}`);
-  }
-}
-
 async function cleanupProductGroups(
   client: IApimClient,
   context: ApimServiceContext,
@@ -178,27 +137,6 @@ async function cleanupProductGroups(
   }
 }
 
-function parseSubscriptionDescriptor(
-  subscription: Record<string, unknown>,
-  context: ApimServiceContext
-): ResourceDescriptor | undefined {
-  if (typeof subscription.id === 'string') {
-    const parsed = parseArmUri(subscription.id, context);
-    if (parsed?.type === ResourceType.Subscription) {
-      return parsed;
-    }
-  }
-
-  if (typeof subscription.name === 'string' && subscription.name.length > 0) {
-    return {
-      type: ResourceType.Subscription,
-      nameParts: [subscription.name],
-    };
-  }
-
-  return undefined;
-}
-
 function parseProductGroupDescriptor(
   productGroup: Record<string, unknown>,
   context: ApimServiceContext

tests/unit/services/product-publisher.test.ts

@@ -283,7 +283,7 @@ describe('product-publisher', () => {
       expect(result.error?.message).toBe('Unexpected store error');
     });
 
-    it('deletes auto-generated product subscriptions after product publish', async () => {
+    it('does not delete auto-generated product subscriptions after product publish', async () => {
       const client = createMockClient();
       const store = createMockStore();
       const autoGeneratedId = generatedSubscriptionId('c');
@@ -305,7 +305,7 @@ describe('product-publisher', () => {
       const result = await publishProduct(client, store, testContext, productDescriptor, testConfig);
 
       expect(result.status).toBe('success');
-      expect(client.deleteResource).toHaveBeenCalledWith(
+      expect(client.deleteResource).not.toHaveBeenCalledWith(
         testContext,
         expect.objectContaining({
           type: ResourceType.Subscription,
@@ -314,7 +314,7 @@ describe('product-publisher', () => {
       );
     });
 
-    it('deletes product-scoped subscriptions on first product creation regardless of displayName', async () => {
+    it('does not delete product-scoped subscriptions on first product creation', async () => {
       const client = createMockClient();
       const store = createMockStore();
       client.getResource.mockResolvedValue(undefined);
@@ -335,7 +335,7 @@ describe('product-publisher', () => {
       const result = await publishProduct(client, store, testContext, productDescriptor, testConfig);
 
       expect(result.status).toBe('success');
-      expect(client.deleteResource).toHaveBeenCalledWith(
+      expect(client.deleteResource).not.toHaveBeenCalledWith(
         testContext,
         expect.objectContaining({
           type: ResourceType.Subscription,