fixing sub limit issue with target apim

Author: EMaher

tests/integration/all-resource-types/Deploy-TargetApim.ps1

@@ -108,4 +108,50 @@ if (-not $result.properties.outputs) {
 
 Write-Host "✅ Target APIM deployed successfully: $(Protect-ApimName -Value $result.properties.outputs.apimServiceName.value)"
 
+# APIM may auto-create default user subscriptions (for built-in products like
+# starter/unlimited). Remove non-system subscriptions so publish starts from a
+# clean target with no user subscriptions.
+$targetApimName = $result.properties.outputs.apimServiceName.value
+Write-Host "Pruning non-system subscriptions from target APIM..."
+
+$listArgs = @(
+  'apim', 'subscription', 'list',
+  '--resource-group', $ResourceGroupName,
+  '--service-name',   $targetApimName,
+  '--output',         'json'
+)
+
+$subsRaw = Invoke-MaskedAzCommand -Replacements $azReplacements -Arguments $listArgs
+if ($LASTEXITCODE -ne 0) {
+  throw "Failed to list target APIM subscriptions"
+}
+
+$subscriptions = $subsRaw | ConvertFrom-Json
+$deletedCount = 0
+
+foreach ($sub in @($subscriptions)) {
+  $sid = $sub.name
+  if (-not $sid -or $sid -eq 'master') {
+    continue
+  }
+
+  $deleteArgs = @(
+    'apim', 'subscription', 'delete',
+    '--resource-group', $ResourceGroupName,
+    '--service-name',   $targetApimName,
+    '--sid',            $sid,
+    '--yes',
+    '--output',         'none'
+  )
+
+  Invoke-MaskedAzCommand -Replacements $azReplacements -Arguments $deleteArgs | Out-Null
+  if ($LASTEXITCODE -eq 0) {
+    $deletedCount++
+  } else {
+    throw "Failed to delete target APIM subscription '$sid'"
+  }
+}
+
+Write-Host "✅ Pruned $deletedCount non-system subscriptions from target APIM"
+
 return $result.properties.outputs

tests/integration/all-resource-types/run-roundtrip-test.ps1

@@ -565,32 +565,6 @@ try {
 
     Write-Host ""
 
-    # -----------------------------------------------------------------------
-    # Phase 2.2: Prune non-deterministic subscriptions from extracted artifacts
-    # -----------------------------------------------------------------------
-    Write-Phase "🧼" "PHASE 2.2 — Prune non-deterministic subscriptions"
-
-    $subscriptionRoots = Get-ChildItem -Path $ExtractOutputDir -Recurse -Directory -ErrorAction SilentlyContinue |
-        Where-Object { $_.Name -eq 'subscriptions' }
-
-    $autoIdPattern = '^[0-9a-f]{24}$|^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$'
-    $prunedCount = 0
-
-    foreach ($root in $subscriptionRoots) {
-        $autoIdDirs = Get-ChildItem -Path $root.FullName -Directory -ErrorAction SilentlyContinue |
-            Where-Object { $_.Name -match $autoIdPattern }
-
-        foreach ($dir in $autoIdDirs) {
-            Remove-Item -Path $dir.FullName -Recurse -Force -ErrorAction SilentlyContinue
-            $prunedCount++
-        }
-    }
-
-    Write-Host "   Pruned auto-generated subscription directories: $prunedCount"
-    Write-PhaseEnd "🧼" "PHASE 2.2 complete — deterministic subscriptions retained"
-
-    Write-Host ""
-
     # -----------------------------------------------------------------------
     # Phase 2.5: Generate override config for target environment
     # -----------------------------------------------------------------------