add handling for existing association links in product and resource publishers

Author: EMaher

src/clients/apim-client.ts

@@ -31,6 +31,16 @@ export class HttpError extends Error {
   }
 }
 
+/**
+ * Returns true when the error indicates an association link already exists.
+ * APIM returns HTTP 409 Conflict ("Link already exists between specified ...")
+ * when an association is re-created; the desired end state is already in place,
+ * so callers treat it as an idempotent success rather than a failure.
+ */
+export function isLinkAlreadyExistsError(error: unknown): boolean {
+  return error instanceof HttpError && error.status === 409;
+}
+
 export class ApimClient implements IApimClient {
   private credential: DefaultAzureCredential;
   private readonly authScope: string;

src/services/product-publisher.ts

@@ -15,6 +15,7 @@ import { logger } from '../lib/logger.js';
 import { getNamePart } from '../lib/resource-path.js';
 import { parseArmUri } from '../lib/resource-uri.js';
 import { isWorkspaceScope, buildLinkPayload } from '../lib/workspace-link.js';
+import { isLinkAlreadyExistsError } from '../clients/apim-client.js';
 
 /**
  * Publish a Product with all its associations (APIs, Groups, Tags).
@@ -206,6 +207,10 @@ async function publishProductAssociations(
       await client.putResource(context, assocDescriptor, payload);
       logger.debug(`Created ${resourceType} association: ${productName}/${name}`);
     } catch (error) {
+      if (isLinkAlreadyExistsError(error)) {
+        logger.debug(`${resourceType} association already exists: ${productName}/${name}`);
+        continue;
+      }
       logger.warn(`Failed to create ${resourceType} association ${productName}/${name}: ${String(error)}`);
     }
   }
@@ -259,6 +264,10 @@ async function publishProductTags(
       await client.putResource(context, tagDescriptor, payload);
       logger.debug(`Created ProductTag association: ${productName}/${tagName}`);
     } catch (error) {
+      if (isLinkAlreadyExistsError(error)) {
+        logger.debug(`ProductTag association already exists: ${productName}/${tagName}`);
+        continue;
+      }
       logger.warn(`Failed to create ProductTag association ${productName}/${tagName}: ${String(error)}`);
     }
   }

src/services/resource-publisher.ts

@@ -19,6 +19,7 @@ import { isAutoGeneratedId } from '../lib/auto-generated.js';
 import { isWorkspaceScope, buildLinkPayload } from '../lib/workspace-link.js';
 import { logger } from '../lib/logger.js';
 import { REDACTION_MARKER } from './secret-redactor.js';
+import { isLinkAlreadyExistsError } from '../clients/apim-client.js';
 import type { OverrideConfig } from '../models/config.js';
 
 export interface ResourcePublishResult {
@@ -308,8 +309,15 @@ async function publishAssociation(
         type: descriptor.type,
         nameParts: [getNamePart(descriptor.nameParts, 0), entry.name],
       };
-      // PUT empty body for association (APIM uses PUT to create association)
-      await client.putResource(context, assocDescriptor, {});
+      try {
+        // PUT empty body for association (APIM uses PUT to create association)
+        await client.putResource(context, assocDescriptor, {});
+      } catch (error) {
+        // 409 means the link already exists — desired state is in place.
+        if (!isLinkAlreadyExistsError(error)) {
+          throw error;
+        }
+      }
     }
 
     return {
@@ -616,7 +624,14 @@ async function publishWorkspaceApiTagLink(
     }
     const payload = buildLinkPayload(context, meta.workspaceLinkIdProperty, 'apis', apiName, descriptor.workspace);
 
-    await client.putResource(context, descriptor, payload);
+    try {
+      await client.putResource(context, descriptor, payload);
+    } catch (error) {
+      // 409 means the tag/api link already exists — desired state is in place.
+      if (!isLinkAlreadyExistsError(error)) {
+        throw error;
+      }
+    }
 
     return {
       descriptor,