26-ITP-Jan | Onboarding |Ayodeji Ayorinde

[Ayogit1]

Demo Attendance:

Online Study Session:
https://codeyourfutur-yov6609.slack.com/files/U0A6D4JPQSW/F0ABEQKL1F0/image.png

A link to your completed pull request for “Wireframe to Web Code”:
CodeYourFuture/Module-Onboarding#1095

A link to your completed pull request for “Form Controls”:
CodeYourFuture/Module-Onboarding#1141

Your Codewars username which you created when you joined Codewars:
Ayocodewars1

A link showing you completed at least 50% of the Onboarding katas:
https://codeyourfuture.github.io/Codewars-Progress-Checker/#Ayocodewars1

[cjyuan]

• Regarding your Wireframe PR. If you have made changes and want the reviewer to review your changes, you should

  1. Respond to the reviewer's comments. Doing so will usually get the reviewer's notified.
  2. Add "Needs review " label

• The Form-Controls PR you shared was outdated. You have opened a new one.

This issue is correctly prepared. We are just waiting for both of your PRs to complete before we can approve your Step 1.

[Ayogit1]

The new link is as below:
CodeYourFuture/Module-Onboarding#1141

[cjyuan]

Can you update the link in the issue description with the link you just shared?

[Ayogit1]

@cjyuan , I have made an attempt to update based on my understanding. I have also asked for help on slack and sent a DM to you so I can get this resolved quickly.

[cjyuan]

This issue is now correctly prepared for Step 1 submission, but we can only approve your Step 1 after both of your PRs have completed.

Currently they are in "Reviewed" status. If they are ready to be re-reviewed, you need to add "Needs Review" label to them.

[Ayogit1]

Both PRs tasks are completely executed. Form has been approved. I'm hoping Wireframe will be approved few hours from now.

Wireframe:
CodeYourFuture/Module-Onboarding#1095

Form:
CodeYourFuture/Module-Onboarding#1141

[cjyuan]

Layout

When I open your Wireframe page, this is what I see:

• The articles overlap.
• The footer is not fixed at the bottom of the viewport.

Lighthouse Accessibility Score

• Score is 97

---

Suggestion: Use an AI tool to review your code and ask it to suggest possible improvement in terms of accessibility, typo, consistency.

I don't want to jump into your PR as it already has a reviewer, but I think you should address these issues to make you implementation more ready.

[Ayogit1]

Webpage updated:
Link: http://127.0.0.1:5500/Wireframe/index.html

Lighthouse Analysis:

[cjyuan]

• The footer should be fixed at the bottom of the viewport. (Ask AI what this statement means).

  • Note: This is part of the requirements specified in README.md.

• To better match the wireframe image, you may want to

  • Center the the text on the footer.
  • Show the border for all three articles
  • Align the left border of article 1 and the left border of article 2
  • Align the right border of article 1 and the right border of article 3
  • Align the height of the image in articles 2 and 3.

Note: The IP 127.0.0.1 in the URL means it is "localhost"; the URL will only work on your computer.

[Ayogit1]

@cjyuan ,
Issues all fixed.

http://127.0.0.1:5500/Wireframe/index.html

[cjyuan]

The page looks much better now.

• Currently the footer content and the page content can overlap (see pic). It would be better to prevent this from happening.

• In the wireframe image, the text on the footer is centered. Ideally it would also be like that in your implementation.

Note: The URL you shared, http://127.0.0.1:5500/Wireframe/index.html will only work on your computer.

[Ayogit1]

The footer is now centre-aligned. I'm not sure I can make the enrolment in five days time as the Wireframe PR has prevented me from making meaningful progress in ITP. Some colleagues with Wireframe not as detailed as mine got theirs approved and I understand that such work are beginner's efforts with with room for improvement down the line. I have now started considering not to return to class on Saturday if the Wireframe PR will stop me from enrolment. This is completely new to me and I understand that I may not be able to create something perfect to move on to enrolment but thanks for all your efforts.

[cjyuan]

• Now, the footer is no longer fixed at the bottom of the viewport.

You only need this PR to complete to complete Step 1.

I can step in your PR review if you fix the footer.

[cjyuan]

Step 1 approved.