Skip to content

Commit d7e339e

Browse files
JLouPIERMÉ Jean-Lou
and
PIERMÉ Jean-Lou
authored
ci(all): fix missing esm build files (#998)
Because npm pack ignores folders and files listed in gitignore, the esm build directory for the `all` package was not included in the tarball pushed to the registry. I moved the gitignore line to the root of the repo and now it should work properly. Letting us finally use the toolkit with vite for example! Co-authored-by: PIERMÉ Jean-Lou <[email protected]>
1 parent fbf7053 commit d7e339e

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ yarn-error.log*
99
/**/storybook-static/
1010
/**/axa-static/
1111
/**/dist/
12+
/**/esm/
1213
/**/.toolkit/
1314
jest-test-results.json
1415
/packages/**/LICENSE

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ npm install
3131
After installing dependencies, it's necessary to build all package via `lerna` with:
3232

3333
```sh
34-
npm build
34+
npm run build
3535
```
3636

3737
At this point you are ready to contribute.

packages/all/.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
component
2-
esm
2+

packages/all/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"types": "esm/index.d.ts",
77
"private": false,
88
"scripts": {
9-
"build": "rimraf ./component rimraf ./esm && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json"
9+
"prebuild": "rimraf ./component & rimraf ./esm",
10+
"build": "tsc -p tsconfig.json & tsc -p tsconfig-cjs.json"
1011
},
1112
"peerDependencies": {
1213
"react": "^16.8.0 || ^17.0.0 || ^18.0.0",

0 commit comments

Comments
 (0)