fix: resolve #705 — Failed to delete datatype#819
Conversation
Fixes Autonomy-Logic#705 Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
Fixes Autonomy-Logic#705 Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
Fixes Autonomy-Logic#705 Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
|
Warning Review limit reached
More reviews will be available in 12 minutes and 21 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
fix: resolve #705 — Failed to delete datatype
Problem
Severity:
Critical| File:src/renderer/components/datatypes/datatype-manager.tsxThe deletion logic is incorrectly using the currently opened datatype instead of the selected datatype for deletion. This causes the wrong item to be deleted when the user is viewing a different datatype than the one they want to delete.
Solution
Modify the deletion handler to pass and use the specific datatype ID that was selected for deletion, rather than relying on the currently active/opened datatype context.
Changes
src/renderer/components/datatypes/datatype-manager.tsx(new)src/renderer/components/datatypes/datatype-list.tsx(new)src/renderer/store/datatypes/actions.ts(new)Testing