Skip to content

fix: resolve #647 — Modbus master for Arduino and ESP cards#810

Open
andoan16 wants to merge 4 commits into
Autonomy-Logic:developmentfrom
andoan16:contribai/feat/add-modbus-master-support-for-arduino-es
Open

fix: resolve #647 — Modbus master for Arduino and ESP cards#810
andoan16 wants to merge 4 commits into
Autonomy-Logic:developmentfrom
andoan16:contribai/feat/add-modbus-master-support-for-arduino-es

Conversation

@andoan16

Copy link
Copy Markdown

Summary

fix: resolve #647 — Modbus master for Arduino and ESP cards

Problem

Severity: High | File: resources/sources/Baremetal/Baremetal.ino

The main Arduino sketch file needs to be modified to include Modbus master functionality. This will involve adding Modbus communication libraries and implementation code to support master operations on Arduino and ESP boards.

Solution

Add conditional compilation directives to include Modbus master libraries and initialization code. Implement functions for Modbus master operations such as reading/writing registers, handling different slave devices, and managing serial communication for both Arduino Uno and ESP32/ESP8266 platforms.

Changes

  • resources/sources/Baremetal/Baremetal.ino (modified)
  • resources/sources/Baremetal/arduino_libs.h (modified)
  • resources/sources/Baremetal/modules/sm_cards.c (modified)
  • resources/sources/Baremetal/c_blocks_code.cpp (modified)

Testing

  • Existing tests pass
  • Manual review completed
  • No new warnings/errors introduced

andoan16 added 4 commits May 31, 2026 09:31
…ards

Fixes Autonomy-Logic#647

Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
…ards

Fixes Autonomy-Logic#647

Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
…ards

Fixes Autonomy-Logic#647

Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
…ards

Fixes Autonomy-Logic#647

Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • resources/sources/Baremetal/Baremetal.ino is excluded by !resources/**
  • resources/sources/Baremetal/arduino_libs.h is excluded by !resources/**
  • resources/sources/Baremetal/c_blocks_code.cpp is excluded by !resources/**
  • resources/sources/Baremetal/modules/sm_cards.c is excluded by !resources/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 108def91-2f3d-4510-8424-835ed3fa83b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modbus master for Arduino and ESP cards

1 participant