fix(build): cross-platform pkg binaries via --no-bytecode (#132)#143
Merged
Conversation
The v0.4.21 release built all binaries but the Windows .exe crashed at launch: "[pkg] V8 rejected the bytecode cache ... mismatched host/target V8 (cross-platform bytecode)". The Windows binary is cross-compiled on Linux, and pkg's default V8 bytecode is not portable across host/target platforms; @yao-pkg's newer V8 rejects it at runtime. Add `--no-bytecode --public-packages "*" --public` to every pkg invocation (release.yml x5, ci.yml binary-smoke, package.json build:pkg*) so the snapshot ships plain JS instead of platform-specific bytecode. Fine for a GPL project. The new smoke-windows job caught this before any release was published (create-release was skipped). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…build fix(build): disable pkg V8 bytecode for cross-platform binaries (#132)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the cross-platform binary fix to main (PR #142) so the v0.4.21 release can be re-triggered.
The prior v0.4.21 build produced all binaries but the cross-built Windows
.execrashed (V8 rejected Linux-built bytecode);smoke-windowsblocked the release, so nothing was published. This adds--no-bytecode --public-packages "*" --publicto everypkgcall.After merge, the v0.4.21 tag will be re-created on this commit to kick the release.
🤖 Generated with Claude Code