Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenlypso: flush stores when site is switched #29369

Closed
vindl opened this issue Dec 12, 2018 · 0 comments · Fixed by #29445
Closed

Gutenlypso: flush stores when site is switched #29369

vindl opened this issue Dec 12, 2018 · 0 comments · Fixed by #29445
Assignees
@Copons
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] BLOCKER Requires immediate attention. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@vindl
Copy link
Member

vindl commented Dec 12, 2018

We need to flush the core editor stores when we switch sites. Otherwise old site data will remain in the store and be incorrectly displayed for newly selected sites too.

See #28302 (review) for context.
@vindl vindl added [Pri] BLOCKER Requires immediate attention. Accessibility (a11y) [Goal] Gutenberg Working towards full integration with Gutenberg labels Dec 12, 2018
@vindl vindl self-assigned this Dec 12, 2018
@vindl vindl added [Type] Bug When a feature is broken and / or not performing as intended and removed Accessibility (a11y) labels Dec 12, 2018
@vindl vindl changed the title Gutenberg: flush stores when site is switched Gutenlypso: flush stores when site is switched Dec 12, 2018
@vindl vindl removed their assignment Dec 13, 2018
@Copons Copons self-assigned this Dec 14, 2018
@Copons Copons mentioned this issue Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Copons Copons

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] BLOCKER Requires immediate attention. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gutenberg: Reset core resolvers on site change Automattic/wp-calypso
2 participants
@vindl @Copons