Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection docs reference deprecated fields option #303

Closed
w33ble opened this issue Apr 27, 2020 · 1 comment · Fixed by #304
Closed

Collection docs reference deprecated fields option #303

w33ble opened this issue Apr 27, 2020 · 1 comment · Fixed by #304

Comments

@w33ble
Copy link

w33ble commented Apr 27, 2020

I noticed this when using findOne. I had naively followed the monk docs and passed a fields option to the method. However, that option has been deprecated for at least a couple years based on the mongodb commits. You can also see that it's deprecated in the mongodb docs which are linked to from the monk docs.

The monk docs should probably be updated to use the projection option instead, which is a direct replacement for fields.
@thisguymartin thisguymartin mentioned this issue Apr 28, 2020
Merged
@matburnham matburnham mentioned this issue May 23, 2020
Open
@matburnham
Copy link

While #304 fixes this in terms of findOne's documentation there are still references to fields in other places such as the find documentation. These should also be fixed.

Also see #308 for more concerns re: this documentation not quite reflecting reality and sending me down a rabbit hole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(collection): uses projection, added on find thisguymartin/monk
2 participants
@w33ble @matburnham