Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: AVIF support in CDN #41753

Open
ocabj opened this issue Feb 12, 2025 · 3 comments · May be fixed by #41760
Open

Enhancement: AVIF support in CDN #41753

ocabj opened this issue Feb 12, 2025 · 3 comments · May be fixed by #41760
Assignees
@jeherve
Labels
[Experiment] AI labels added [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Related Posts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@ocabj
Copy link

ocabj commented Feb 12, 2025

Impacted plugin

Jetpack

What

Jetpack Related Posts thumbnails do not display AVIF images

How

If AVIF images are used for the featured image of a wordpress post and that post is displayed as a Related Post on another post, the image will not display. This appears to be a known issue per this old discussion from over a year ago - https://wordpress.org/support/topic/broken-images-for-related-posts-due-to-use-of-wp-cdn/

Wordpress supports AVIF officially as of 6.5 (Feb 2024?) and thus AVIF is going to get more use to justify AVIF support at the Jetpack CDN.
@ocabj ocabj added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 12, 2025
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Related Posts labels Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

OpenAI suggested the following labels for this issue:

  • [Feature Group] Content Management: The issue relates to how content is managed and displayed on WordPress sites, specifically regarding image support in related posts.
  • [Feature] Related Posts: The issue specifically discusses the display of images in Jetpack Related Posts, highlighting a problem with image formats.
  • [Feature] Photon: Photon is related to Jetpack's image CDN functionality, which is relevant here since the enhancement discusses AVIF support in the context of image delivery.

@jeherve
Copy link
Member

jeherve commented Feb 12, 2025

Thanks for the report. I'll close this as a duplicate of #35432, where we already discuss better support for AVIF files in Jetpack's image CDN.

@jeherve jeherve closed this as completed Feb 12, 2025
@jeherve jeherve mentioned this issue Feb 12, 2025
Open
@jeherve
Copy link
Member

jeherve commented Feb 12, 2025

I'll reopen this because we should still ensure that images in related posts aren't broken.

@jeherve jeherve reopened this Feb 12, 2025
jeherve added a commit that referenced this issue Feb 12, 2025
@jeherve
Photon: don't attempt to process images with unsupported extension
32c1215 
Fixes #41753
See #35432

Since Photon does not support AVIF yet, it should never attempt to serve images using that file format. Yet, we do not check for supported extensions when using `Jetpack_PostImages::fit_image_url()` (and thus `Image_CDN_Core::cdn_url()`). Let's fix that.
@jeherve jeherve linked a pull request Feb 12, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Experiment] AI labels added [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Related Posts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Photon: don't attempt to process images with unsupported extension Automattic/jetpack
2 participants
@jeherve @ocabj