From 5cb9c3f0954c60a19ba41df63e04fd9473d7823a Mon Sep 17 00:00:00 2001 From: ryfactor <6005108+ryfactor@users.noreply.github.com> Date: Mon, 15 Dec 2025 14:17:57 +1300 Subject: [PATCH 1/2] Update macOS version for build workflow Update to `macos-15-intel`. Note this is the last intel version before ARM64. See https://github.com/actions/runner-images/issues/13046 for further details. --- .github/workflows/build-osx-wizmode.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-osx-wizmode.yml b/.github/workflows/build-osx-wizmode.yml index aa3f6657e..57af67cd6 100644 --- a/.github/workflows/build-osx-wizmode.yml +++ b/.github/workflows/build-osx-wizmode.yml @@ -14,7 +14,7 @@ env: jobs: build: # custom libpng build fails a test on macos-latest (11.x) - runs-on: macos-13 + runs-on: macos-15-intel steps: - uses: actions/checkout@v2 with: From c68ff5fbcb246819ff73f3698778a06d06c1cea4 Mon Sep 17 00:00:00 2001 From: ryfactor <6005108+ryfactor@users.noreply.github.com> Date: Mon, 15 Dec 2025 14:54:23 +1300 Subject: [PATCH 2/2] Use std::vector instead of VLA for MIDI buffer Replaced variable length array with std::vector for buffer. --- audio/RtMidi.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/audio/RtMidi.cpp b/audio/RtMidi.cpp index fc4a3aa0c..3b28f84aa 100644 --- a/audio/RtMidi.cpp +++ b/audio/RtMidi.cpp @@ -1032,9 +1032,10 @@ void MidiOutCore :: sendMessage( std::vector *message ) return; } - Byte buffer[nBytes+(sizeof(MIDIPacketList))]; - ByteCount listSize = sizeof(buffer); - MIDIPacketList *packetList = (MIDIPacketList*)buffer; + // Replace the buffer VLA with a std::vector-based buffer to avoid VLA. + std::vector bufferVec(nBytes + sizeof(MIDIPacketList)); + ByteCount listSize = static_cast(bufferVec.size()); + MIDIPacketList *packetList = reinterpret_cast(bufferVec.data()); MIDIPacket *packet = MIDIPacketListInit( packetList ); ByteCount remainingBytes = nBytes;