Skip to content

Commit 99a81e5

Browse files
committed
added autoElectFacet and autoStateFacet to replace electFacet and stateFacet from project explorer
1 parent c736ed3 commit 99a81e5

File tree

7 files changed

+40
-16
lines changed

7 files changed

+40
-16
lines changed

.github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
run: node_modules/karma/bin/karma start karma.conf.js --single-run --browsers ChromeHeadless
8282

8383
- name: Run MERIT functional tests
84-
run: ./src/main/scripts/runFunctionalTests.sh
84+
run: ./src/main/scripts/runFunctionalTests.sh chromeHeadless /tmp/ecodata feature/issue3430
8585
env:
8686
GPR_USER: ${{env.GITHUB_ACTOR}}
8787
GPR_TOKEN: ${{secrets.GITHUB_TOKEN}}

grails-app/conf/data/meritHub.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"adminFacets" : [
3-
"electFacet",
3+
"autoElectFacet",
44
"cmzFacet",
55
"meriPlanAssetFacet",
66
"partnerOrganisationTypeFacet",
@@ -13,14 +13,14 @@
1313
"associatedProgramFacet",
1414
"associatedSubProgramFacet",
1515
"mainThemeFacet",
16-
"stateFacet",
16+
"autoStateFacet",
1717
"nrmFacet",
1818
"lgaFacet",
1919
"mvgFacet",
2020
"ibraFacet",
2121
"imcra4_pbFacet",
2222
"otherFacet",
23-
"electFacet",
23+
"autoElectFacet",
2424
"cmzFacet",
2525
"meriPlanAssetFacet",
2626
"partnerOrganisationTypeFacet",
@@ -34,12 +34,12 @@
3434
"organisationFacet",
3535
"associatedProgramFacet",
3636
"associatedSubProgramFacet",
37-
"stateFacet",
37+
"autoStateFacet",
3838
"nrmFacet",
3939
"lgaFacet",
4040
"ibraFacet",
4141
"imcra4_pbFacet",
42-
"electFacet",
42+
"autoElectFacet",
4343
"cmzFacet",
4444
"primaryOutcomeFacet"
4545
],

grails-app/i18n/messages.properties

+2
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ label.associatedProgramFacet=Program
275275
label.associatedSubProgramFacet=Sub Program
276276
label.assessment=Assessment
277277
label.stateFacet=State
278+
label.autoStateFacet=State
278279
label.lgaFacet=<abbr title="Local Government Areas">LGA</abbr>
279280
label.nrmFacet=<abbr title="Natural Resource Management Areas">Management Areas</abbr>
280281
label.muFacet=<abbr title="Management Unit">Management Unit</abbr>
@@ -285,6 +286,7 @@ label.imcra4_pbFacet=<abbr title="Marine Region">Marine Regions</abbr>
285286
label.otherFacet=<abbr title="Other areas">Other Regions</abbr>
286287
label.status=<abbr title="Project status">Project Status</abbr>
287288
label.electFacet = <abbr title="Project status">Federal Electorates</abbr>
289+
label.autoElectFacet = <abbr title="Project linked to electorates">Federal Electorates</abbr>
288290
label.cmzFacet = <abbr title="Conservation Management Zones">CMZ</abbr>
289291
label.meriPlanAssetFacet=<abbr title="Assets addressed in the MERI plan">Assets Addressed</abbr>
290292
label.partnerOrganisationTypeFacet=<abbr title="Organisation type of partner organisations">Partner Organisations</abbr>

grails-app/services/au/org/ala/merit/SearchService.groovy

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class SearchService {
6060
params.fsort = "term"
6161
params.offset = 0
6262
params.query = "geo.loc.lat:*"
63-
params.facets = "stateFacet,nrmFacet,lgaFacet,mvgFacet"
63+
params.facets = "autoStateFacet,nrmFacet,lgaFacet,mvgFacet"
6464
def url = elasticBaseUrl + commonService.buildUrlParamsFromMap(params)
6565
log.debug "allGeoPoints - $url with $params"
6666
webService.getJson(url)
@@ -225,7 +225,7 @@ class SearchService {
225225
params.remove("ids");
226226
def idList = ids.tokenize(",")
227227
params.query = "_id:" + idList.join(" OR _id:")
228-
params.facets = "stateFacet,nrmFacet,lgaFacet,mvgFacet"
228+
params.facets = "autoStateFacet,nrmFacet,lgaFacet,mvgFacet"
229229
def url = grailsApplication.config.getProperty('ecodata.baseUrl') + 'search/elasticPost'
230230
webService.doPost(url, params)
231231
} else if (params.query) {

grails-app/services/au/org/ala/merit/SettingService.groovy

+3-3
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ class SettingService {
8888
title:'Default',
8989
skin:'ala2',
9090
urlPath:grailsApplication.config.getProperty('app.default.hub', String, 'default'),
91-
availableFacets: ['status', 'organisationFacet','associatedProgramFacet','associatedSubProgramFacet','mainThemeFacet','stateFacet','nrmFacet','lgaFacet','mvgFacet','ibraFacet','imcra4_pbFacet','otherFacet', 'gerSubRegionFacet','electFacet'],
92-
adminFacets: ['electFacet'],
93-
availableMapFacets: ['status', 'organisationFacet','associatedProgramFacet','associatedSubProgramFacet','stateFacet','nrmFacet','lgaFacet','mvgFacet','ibraFacet','imcra4_pbFacet','electFacet']
91+
availableFacets: ['status', 'organisationFacet','associatedProgramFacet','associatedSubProgramFacet','mainThemeFacet','autoStateFacet','nrmFacet','lgaFacet','mvgFacet','ibraFacet','imcra4_pbFacet','otherFacet', 'gerSubRegionFacet','autoElectFacet'],
92+
adminFacets: ['autoElectFacet'],
93+
availableMapFacets: ['status', 'organisationFacet','associatedProgramFacet','associatedSubProgramFacet','autoStateFacet','nrmFacet','lgaFacet','mvgFacet','ibraFacet','imcra4_pbFacet','autoElectFacet']
9494
)
9595
}
9696
if (log.isDebugEnabled()) {

src/integration-test/resources/data/meritHub.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var meritHub = {
22
"adminFacets" : [
3-
"electFacet",
3+
"autoElectFacet",
44
"cmzFacet",
55
"meriPlanAssetFacet",
66
"partnerOrganisationTypeFacet",
@@ -14,14 +14,14 @@ var meritHub = {
1414
"associatedSubProgramFacet",
1515
"muFacet",
1616
"mainThemeFacet",
17-
"stateFacet",
17+
"autoStateFacet",
1818
"nrmFacet",
1919
"lgaFacet",
2020
"mvgFacet",
2121
"ibraFacet",
2222
"imcra4_pbFacet",
2323
"otherFacet",
24-
"electFacet",
24+
"autoElectFacet",
2525
"cmzFacet",
2626
"meriPlanAssetFacet",
2727
"partnerOrganisationTypeFacet",
@@ -35,12 +35,12 @@ var meritHub = {
3535
"organisationFacet",
3636
"associatedProgramFacet",
3737
"associatedSubProgramFacet",
38-
"stateFacet",
38+
"autoStateFacet",
3939
"nrmFacet",
4040
"lgaFacet",
4141
"ibraFacet",
4242
"imcra4_pbFacet",
43-
"electFacet",
43+
"autoElectFacet",
4444
"cmzFacet",
4545
"primaryOutcomeFacet"
4646
],
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
load( "../../utils/audit.js");
2+
var oldAndNewFacets = {electFacet: 'autoElectFacet', stateFacet: 'autoStateFacet'}
3+
var propsToCheck = ["adminFacets", "availableFacets", "availableMapFacets", "officerFacets"]
4+
var oldFacets = Object.keys(oldAndNewFacets);
5+
var adminUserId = "system";
6+
db.hub.find({urlPath:'merit'}).forEach(function (hub){
7+
propsToCheck.forEach(function (prop){
8+
if (hub[prop]) {
9+
for(var index = 0; index < oldFacets.length; index++) {
10+
var oldFacet = oldFacets[index];
11+
var indexOfOldFacet = hub[prop].indexOf(oldFacet);
12+
if( indexOfOldFacet >= 0) {
13+
hub[prop][indexOfOldFacet] = oldAndNewFacets[oldFacet];
14+
}
15+
}
16+
}
17+
});
18+
19+
db.hub.updateOne({hubId: hub.hubId}, {$set: hub});
20+
audit(hub, hub.hubId, 'au.org.ala.ecodata.Hub', adminUserId, undefined, "Update");
21+
print(`Updated hub - ${hub.urlPath}`);
22+
});

0 commit comments

Comments
 (0)