Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinImagen/images/x_tm1.png the formula is not correct #13

Open
kylehh opened this issue Mar 3, 2023 · 0 comments
Open

MinImagen/images/x_tm1.png the formula is not correct #13

kylehh opened this issue Mar 3, 2023 · 0 comments

Comments

@kylehh
Copy link

kylehh commented Mar 3, 2023

The formula is in this picture is supposed to be sampling from the q_posterior (formula in MinImagen/images/q_posterior.png)
So the normal distribution should be x(t-1) = mu(t) + sqrt(beta) * noise (beta is var here)

The code is correct in Imagen.py, which proof that the formula in the picture is wrong( should change minus to plus)
line 370: return model_mean + nonzero_mask * (0.5 * model_log_variance).exp() * noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant