All files created in the staging directory should be world-readable. (#2)

Author: LTLA

src/pygobbler/_utils.py

@@ -27,6 +27,13 @@ def dump_request(staging: str, url: str, action: str, payload: Optional[Dict]) -
     with os.fdopen(fd, "w") as handle:
         handle.write(as_str)
 
+    # Making sure that the gobbler's service account can read this request file.
+    old_umask = os.umask(22) 
+    try:
+        os.chmod(os.path.join(staging, holding_name), 0o644)
+    finally:
+        os.umask(old_umask)
+
     res = requests.post(url + "/new/" + os.path.basename(holding_name))
     if res.status_code >= 300:
         raise format_error(res)

src/pygobbler/upload_directory.py

@@ -58,6 +58,29 @@ def upload_directory(project: str, asset: str, version: str, directory: str, sta
 
         directory = newdir
 
+    # Ensuring that everything is world-readable in this directory.
+    old_umask = os.umask(22) 
+    try:
+        import stat
+        extra_file_args = stat.S_IROTH | stat.S_IRGRP | stat.S_IRUSR
+        extra_dir_args = extra_file_args | stat.S_IXOTH | stat.S_IXGRP | stat.S_IXUSR
+        st = os.stat(directory)
+        if st.st_mode & extra_dir_args != extra_dir_args:
+            os.chmod(directory, st.st_mode | extra_dir_args)
+        for root, dirs, files in os.walk(directory):
+            for name in dirs:
+                path = os.path.join(root, name)
+                st = os.stat(path)
+                if st.st_mode & extra_dir_args != extra_dir_args:
+                    os.chmod(path, st.st_mode | extra_dir_args)
+            for name in files:
+                path = os.path.join(root, name)
+                st = os.stat(path)
+                if st.st_mode & extra_file_args != extra_file_args:
+                    os.chmod(path, st.st_mode | extra_file_args)
+    finally:
+        os.umask(old_umask)
+
     req = {
         "source": os.path.basename(directory),
         "project": project,