[BUG] 'input.acid_to_mine' is never set for 'uranium-ore'

[GavinAnderberg]

Describe the bug
When running the mods (Bobs + Angels) with angelsmods.refining.disable_ore_override = true on line 4 of angelsrefining/data.lua you get an error during startup: Error while running setup for entity prototype "uranium-ore" (resource): Minable properties fluid amount is not zero but a required fluid is not defined.

Poking around to see when the data.raw.resources['uranium-ore'] prototype changes has the following stack trace
angelsrefining/data-updates.lua line 55
-> angelsmods.functions.update_autoplace() in prototypes/generation/resource-builder.lua line 994

Probing the value before and after the loop inside executes shows that before:

data.raw.resource["uranium-ore"].minable = {fluid_amount = 10, mining_particle = "stone-particle", mining_time = 2, required_fluid = "sulfuric-acid", result = "uranium-ore"}
input.acid_req = nil

And after:

data.raw.resource["uranium-ore"].minable = {fluid_amount = 10, mining_particle = "stone-particle", mining_time = 2, result = "uranium-ore"}
input.acid_req = nil

Here it can be seen that the required_fluid field of the prototype has been cleared by line 1023: data.raw.resource[input.name].minable.required_fluid = input.acid_req
Inside the conditional branches of this function input.acid_req is copied over from input.acid_to_mine, which is nil for uranium.
For now I will continue to dig around. I will post an update here when I figure more out.

Also worth noting, the infinite uranium ore seems to be defined correctly.
data.raw.resource["uranium-ore"].minable.required_fluid = "angels-liquid-sulfuric-acid"

To Reproduce
Information to reproduce the behavior:

1. Game Version: 2.0.72

2. Modlist:

core

angelsbioprocessinggraphics

angelsexplorationgraphics

angelsindustriesgraphics

angelspetrochemgraphics

angelsrefininggraphics

angelssmeltinggraphics

base

debug --Empty mod, logs stuff to help find where prototype changes occur

squeak-through-2

angelsaddons-bots

angelsaddons-cab

boblibrary

textplates

Todo-List

bobenemies

bobores

bobplates

bobtech

bobassembly

bobelectronics

bobgreenhouse

boblogistics

bobmining

bobpower

bobrevamp

bobwarfare

bobequipment

bobmodules

bobvehicleequipment

angelsrefining

angelsaddons-mobility

angelsinfiniteores

angelspetrochem

angelsaddons-storage

angelssmelting

angelsbioprocessing

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I know the angelsmods.refining.disable_ore_override = true is a non-standard setting, but I would like to see this be supported in the future as an official mod setting.

[KiwiHawk]

I've never noticed this setting before. From checking the history, it looks like it has always been there.

How do you imagine that this setting should work?

[GavinAnderberg]

I managed to make it work by adding in some code to make sure a resource prototype only every has both or neither fluid_amount or required_fluid. I suspect that (uranium being the only vanilla ore that) the required_fluid attribute is not properly maintained into angelsmods.functions.update_autoplace(). This comes from the angelsmods.functions.store. The change I made can be seen in the fork I made, in this commit.

As far as what I think it should do, I would like to see what happens if I just get it working now. I imagine that it would allow generation of both angels ores and the original bob's ores. I think it would be cool if I could get the settings tweaked in such a way that leads to very mixed patches.

For now, my issues preventing loading stem from the lack of autoplace settings for bob-cobalt-ore

[KiwiHawk]

Without a clear picture of what it does, this isn't something I want to spend time working on or reviewing. I'm be more inclined to remove this setting entirely! If Bob's ores and Angel's ores spawned, I don't see why people would bother with Angel's ores / the whole of Refining mod when they can get the other ores directly.