Warning Suppression CA1062 (#2216)

Author: Zombach

src/Polly/Bulkhead/AsyncBulkheadPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Bulkhead;
 /// <summary>
 /// A bulkhead-isolation policy which can be applied to delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncBulkheadPolicy : AsyncPolicy, IBulkheadPolicy
 {
     private readonly SemaphoreSlim _maxParallelizationSemaphore;

src/Polly/Bulkhead/BulkheadPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Bulkhead;
 /// <summary>
 /// A bulkhead-isolation policy which can be applied to delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class BulkheadPolicy : Policy, IBulkheadPolicy
 {
     private readonly SemaphoreSlim _maxParallelizationSemaphore;

src/Polly/Caching/AsyncCachePolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Caching;
 /// <summary>
 /// A cache policy that can be applied to the results of delegate executions.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncCachePolicy : AsyncPolicy
 {
     private readonly IAsyncCacheProvider _asyncCacheProvider;

src/Polly/Caching/AsyncCacheSyntax.cs

@@ -1,6 +1,7 @@
 #nullable enable
 namespace Polly;
 
+#pragma warning disable CA1062 // Validate arguments of public methods
 public partial class Policy
 {
     /// <summary>

src/Polly/Caching/AsyncCacheTResultSyntax.cs

@@ -1,6 +1,7 @@
 #nullable enable
 namespace Polly;
 
+#pragma warning disable CA1062 // Validate arguments of public methods
 public partial class Policy
 {
     /// <summary>

src/Polly/Caching/CachePolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Caching;
 /// <summary>
 /// A cache policy that can be applied to the results of delegate executions.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class CachePolicy : Policy, ICachePolicy
 {
     private readonly ISyncCacheProvider _syncCacheProvider;

src/Polly/Caching/CacheSyntax.cs

@@ -1,6 +1,7 @@
 #nullable enable
 namespace Polly;
 
+#pragma warning disable CA1062 // Validate arguments of public methods
 public partial class Policy
 {
     /// <summary>

src/Polly/Caching/CacheTResultSyntax.cs

@@ -1,6 +1,7 @@
 #nullable enable
 namespace Polly;
 
+#pragma warning disable CA1062 // Validate arguments of public methods
 public partial class Policy
 {
     /// <summary>

src/Polly/Caching/ContextualTtl.cs

@@ -4,6 +4,7 @@ namespace Polly.Caching;
 /// <summary>
 /// Defines a ttl strategy which will cache items for a TimeSpan which may be influenced by data in the execution context.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class ContextualTtl : ITtlStrategy
 {
     /// <summary>

src/Polly/Caching/DefaultCacheKeyStrategy.cs

@@ -4,6 +4,7 @@ namespace Polly.Caching;
 /// <summary>
 /// The default cache key strategy for <see cref="CachePolicy"/>.  Returns the property <see cref="Context.OperationKey"/>.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class DefaultCacheKeyStrategy : ICacheKeyStrategy
 {
     /// <summary>

src/Polly/CircuitBreaker/AsyncCircuitBreakerPolicy.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// A circuit-breaker policy that can be applied to async delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncCircuitBreakerPolicy : AsyncPolicy, ICircuitBreakerPolicy
 {
     internal readonly ICircuitController<EmptyStruct> BreakerController;

src/Polly/CircuitBreaker/CircuitBreakerPolicy.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// A circuit-breaker policy that can be applied to delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class CircuitBreakerPolicy : Policy, ICircuitBreakerPolicy
 {
     internal readonly ICircuitController<EmptyStruct> BreakerController;

src/Polly/Fallback/AsyncFallbackPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Fallback;
 /// <summary>
 /// A fallback policy that can be applied to asynchronous delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncFallbackPolicy : AsyncPolicy, IFallbackPolicy
 {
     private readonly Func<Exception, Context, Task> _onFallbackAsync;

src/Polly/Fallback/FallbackPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Fallback;
 /// <summary>
 /// A fallback policy that can be applied to delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class FallbackPolicy : Policy, IFallbackPolicy
 {
     private readonly Action<Exception, Context> _onFallback;

src/Polly/NoOp/AsyncNoOpPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.NoOp;
 /// <summary>
 /// A noop policy that can be applied to asynchronous delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncNoOpPolicy : AsyncPolicy, INoOpPolicy
 {
     internal AsyncNoOpPolicy()

src/Polly/NoOp/NoOpPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.NoOp;
 /// <summary>
 /// A no op policy that can be applied to delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class NoOpPolicy : Policy, INoOpPolicy
 {
     internal NoOpPolicy()

src/Polly/Polly.csproj

@@ -7,7 +7,7 @@
     <ProjectType>Library</ProjectType>
     <MutationScore>70</MutationScore>
     <IncludePollyUsings>true</IncludePollyUsings>
-    <NoWarn>$(NoWarn);CA1010;CA1031;CA1051;CA1062;CA1063;CA1064;CA1724;CA1805;CA1816;CA2211</NoWarn>
+    <NoWarn>$(NoWarn);CA1010;CA1031;CA1051;CA1063;CA1064;CA1724;CA1805;CA1816;CA2211</NoWarn>
     <NoWarn>$(NoWarn);S2223;S3215;S4039</NoWarn>
     <!--Public API Analyzers: We do not need to fix these as it would break compatibility with released Polly versions-->
     <NoWarn>$(NoWarn);RS0037;</NoWarn>

src/Polly/RateLimit/AsyncRateLimitPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.RateLimit;
 /// <summary>
 /// A rate-limit policy that can be applied to asynchronous delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncRateLimitPolicy : AsyncPolicy, IRateLimitPolicy
 {
     private readonly IRateLimiter _rateLimiter;

src/Polly/RateLimit/RateLimitPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.RateLimit;
 /// <summary>
 /// A rate-limit policy that can be applied to synchronous delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class RateLimitPolicy : Policy, IRateLimitPolicy
 {
     private readonly IRateLimiter _rateLimiter;

src/Polly/Retry/AsyncRetryPolicy.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// A retry policy that can be applied to asynchronous delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncRetryPolicy : AsyncPolicy, IRetryPolicy
 {
     private readonly Func<Exception, TimeSpan, int, Context, Task> _onRetryAsync;

src/Polly/Retry/RetryPolicy.cs

@@ -4,6 +4,7 @@ namespace Polly.Retry;
 /// <summary>
 /// A retry policy that can be applied to synchronous delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class RetryPolicy : Policy, IRetryPolicy
 {
     private readonly Action<Exception, TimeSpan, int, Context> _onRetry;

src/Polly/Timeout/AsyncTimeoutPolicy.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// A timeout policy which can be applied to async delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class AsyncTimeoutPolicy : AsyncPolicy, ITimeoutPolicy
 {
     private readonly Func<Context, TimeSpan> _timeoutProvider;

src/Polly/Timeout/TimeoutPolicy.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// A timeout policy which can be applied to delegates.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public class TimeoutPolicy : Policy, ITimeoutPolicy
 {
     private readonly TimeoutStrategy _timeoutStrategy;

src/Polly/Wrap/IAsyncPolicyPolicyWrapExtensions.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// Defines extensions for configuring <see cref="PolicyWrap"/> instances on an <see cref="IAsyncPolicy"/> or <see cref="IAsyncPolicy{TResult}"/>.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public static class IAsyncPolicyPolicyWrapExtensions
 {
     /// <summary>

src/Polly/Wrap/IPolicyWrapExtension.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// Extension methods for IPolicyWrap.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public static class IPolicyWrapExtension
 {
     /// <summary>

src/Polly/Wrap/ISyncPolicyPolicyWrapExtensions.cs

@@ -3,6 +3,7 @@
 /// <summary>
 /// Defines extensions for configuring <see cref="PolicyWrap"/> instances on an <see cref="ISyncPolicy"/> or <see cref="ISyncPolicy{TResult}"/>.
 /// </summary>
+#pragma warning disable CA1062 // Validate arguments of public methods
 public static class ISyncPolicyPolicyWrapExtensions
 {
     /// <summary>