Repository navigation
docs: detect AGPL-3.0 and pitch the README for The Next New Thing - #217
Conversation
GitHub licensee scored LICENSE as Other because a copyright grant preceded the AGPL text. Move that grant into LICENSING.md unchanged, and add a plain-language hook, a free-versus-Keepfolio note, and a no-return-claims disclaimer for the YouTube pitch. Co-authored-by: Ossie Irondi <AojdevStudio@users.noreply.github.com>
|
Note The title starts with
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The vendor backlink check links the first prose mention of each vendor in README.md. The new hook is that first mention. Co-authored-by: Ossie Irondi <AojdevStudio@users.noreply.github.com>
There was a problem hiding this comment.
Important
The license detection fix works, but relocating the program notice drops it from Python wheel distributions. Preserve that notice in the package before merging.
Reviewed changes across the license files and README, including GitHub license detection and a targeted wheel build.
- License detection: Removes the project-specific prefix from
LICENSEand preserves its copyright/grant inLICENSING.md; GitHub's API detects this head asAGPL-3.0. - Licensing explanation: Documents the complete free engine, AGPL network-source requirement, separate Keepfolio product, and bring-your-own provider accounts.
- README positioning: Adds the self-hosted audience and pricing pitch, harness links, licensing navigation, demo-replacement TODO, and revised financial disclaimer.
gpt-6.1-sol | 𝕏
Hatchling's default license globs skip LICENSING.md, so the grant moved out of LICENSE was missing from the built package. Co-authored-by: Ossie Irondi <AojdevStudio@users.noreply.github.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the previous Pullfrog review at d32e28d, focused on the packaging fix in 08c01d7.
- Declared legal files: Added explicit
license-filesentries forLICENSEandLICENSING.md, preserving the relocated copyright and license grant in wheel distributions. - Verified distribution contents: Built the wheel and confirmed both legal files match their sources byte-for-byte and appear in its
License-Filemetadata. Validation was targeted to packaging; the full Python test suite was not run.
gpt-6.1-sol | 𝕏

Summary
LICENSEwas the AGPL text with a project copyright grant pasted above it, which dropped licensee similarity under the 98% threshold (the API onmainreportsOther/NOASSERTION). The grant is moved, unchanged, intoLICENSING.md. The terms throughEND OF TERMS AND CONDITIONSare byte-for-byte the AGPL-3.0 text GitHub vendors. No license term was rewritten.LICENSING.mdinlicense-filesso the grant still ships in the wheel. Hatchling's default globs do not match that filename. A local wheel build includes bothLICENSEandLICENSING.mdunder*.dist-info/licenses/.LICENSING.md, based only on what this repo already says.No calculator or application code was changed. The only non-doc edit is the
license-filesentry Pullfrog asked for, so the relocated grant stays in the package.Why this change is needed
The Next New Thing features GitHub repos. The license badge currently says Other, the open-core topic is easy to misread, and the top of the README speaks to operators before it says who the project is for.
For Ossie — conservative calls, not invented terms
Please confirm or correct these. They are flagged because the repo does not settle them, and this PR does not invent an answer.
LICENSING.mdsay Keepfolio is a separate commercial macOS product, its source is not here, and this repo does not state its license. They do not call Keepfolio proprietary or AGPL.or latervsonly. The copyright notice that used to headLICENSEgrants "version 3 or any later version."pyproject.tomland the rootpackage.jsonsayAGPL-3.0-or-later..claude-plugin/plugin.jsonand.claude-plugin/marketplace.jsonsayAGPL-3.0-only. This PR preserves the notice as written and does not edit those manifests..dev/sdk-notes.mdsays "Finance Guru includes proprietary Python-based tooling already." That contradictsdocs/CONTRIBUTING.mdanddocs-site/src/content/docs/explanation/open-core.md, which say the engine, skills, and agents ship under AGPL with no withheld tier. This PR treats the sdk note as stale and does not describe any in-repo proprietary tier.fin-guru/templates/compliance-memo.mdandincome-strategy-template.mduse "proprietary" about generated memos and models. That reads as document boilerplate, not a license on the engine.docs-site/.../open-core.mdstill says plugin packaging is not on the default branch. The plugin manifest and the README install path are on this branch's base. Not edited here.Test Plan
lint-and-testis the suite run.hatchling build -t wheelincludesfamily_office-2.4.1.dist-info/licenses/LICENSEand.../LICENSING.md. The wheelLICENSEhas no 2025 copyright line.LICENSING.mddoes.LICENSEterms throughEND OF TERMS AND CONDITIONSmatch the AGPL-3.0 text in licensee/choosealicense. A length-penalized similarity estimate of the old file is about 91%, under the 98% gate. The new file normalizes to the same text. Pullfrog's review ofd32e28dalso reported GitHub's API detecting that head asAGPL-3.0.Review Checklist
Wiki impact
License detection
After this merges to
main, GitHub's license field should read AGPL-3.0. Detection follows the default branch, so the badge on the repo stays Other until then. Pullfrog already sawAGPL-3.0on the PR head.Summary by CodeRabbit
LICENSE; the project-specific notice and accompanying terms were removed from its opening.