Skip to content

docs: detect AGPL-3.0 and pitch the README for The Next New Thing - #217

Merged
cursor[bot] merged 3 commits into
mainfrom
cursor/youtube-readme-agpl-ff18
Oct 9, 2026
Merged

cursor[bot] merged 3 commits into
mainfrom
cursor/youtube-readme-agpl-ff18

Conversation

@AojdevStudio

@AojdevStudio AojdevStudio commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Makes GitHub's license detector able to read this repo as AGPL-3.0. LICENSE was the AGPL text with a project copyright grant pasted above it, which dropped licensee similarity under the 98% threshold (the API on main reports Other / NOASSERTION). The grant is moved, unchanged, into LICENSING.md. The terms through END OF TERMS AND CONDITIONS are byte-for-byte the AGPL-3.0 text GitHub vendors. No license term was rewritten.
  • Lists LICENSING.md in license-files so the grant still ships in the wheel. Hatchling's default globs do not match that filename. A local wheel build includes both LICENSE and LICENSING.md under *.dist-info/licenses/.
  • Adds a plain-language hook under "Agents propose. Typed code computes.": a self-hosted family office for $0, who it is for, and a "not financial advice; no return claims" note. The existing financial disclaimer now says the same thing.
  • Adds a "What's free / licensing" section to the README and to LICENSING.md, based only on what this repo already says.
  • Leaves an HTML TODO above the current terminal GIF for a future 20-30s clip (Claude Code asks whether a position is too big, a calculator runs, a guardrail blocks). The GIF stays.

No calculator or application code was changed. The only non-doc edit is the license-files entry Pullfrog asked for, so the relocated grant stays in the package.

Why this change is needed

The Next New Thing features GitHub repos. The license badge currently says Other, the open-core topic is easy to misread, and the top of the README speaks to operators before it says who the project is for.

For Ossie — conservative calls, not invented terms

Please confirm or correct these. They are flagged because the repo does not settle them, and this PR does not invent an answer.

  1. Keepfolio's license is not in this repo. The README and LICENSING.md say Keepfolio is a separate commercial macOS product, its source is not here, and this repo does not state its license. They do not call Keepfolio proprietary or AGPL.
  2. or later vs only. The copyright notice that used to head LICENSE grants "version 3 or any later version." pyproject.toml and the root package.json say AGPL-3.0-or-later. .claude-plugin/plugin.json and .claude-plugin/marketplace.json say AGPL-3.0-only. This PR preserves the notice as written and does not edit those manifests.
  3. Stale "proprietary" notes. .dev/sdk-notes.md says "Finance Guru includes proprietary Python-based tooling already." That contradicts docs/CONTRIBUTING.md and docs-site/src/content/docs/explanation/open-core.md, which say the engine, skills, and agents ship under AGPL with no withheld tier. This PR treats the sdk note as stale and does not describe any in-repo proprietary tier.
  4. Template boilerplate. fin-guru/templates/compliance-memo.md and income-strategy-template.md use "proprietary" about generated memos and models. That reads as document boilerplate, not a license on the engine.
  5. Open-core page drift. docs-site/.../open-core.md still says plugin packaging is not on the default branch. The plugin manifest and the README install path are on this branch's base. Not edited here.

Test Plan

  • Docs plus one packaging field. CI lint-and-test is the suite run.
  • Local hatchling build -t wheel includes family_office-2.4.1.dist-info/licenses/LICENSE and .../LICENSING.md. The wheel LICENSE has no 2025 copyright line. LICENSING.md does.
  • LICENSE terms through END OF TERMS AND CONDITIONS match the AGPL-3.0 text in licensee/choosealicense. A length-penalized similarity estimate of the old file is about 91%, under the 98% gate. The new file normalizes to the same text. Pullfrog's review of d32e28d also reported GitHub's API detecting that head as AGPL-3.0.

Review Checklist

  • No secrets or PII committed
  • Documentation updated (if applicable)
  • Test coverage maintained or improved (no calculator change; grant is packaged)

Wiki impact

  • No Wiki update is required.
  • Wiki updated — affected pages and Wiki commit:

License detection

After this merges to main, GitHub's license field should read AGPL-3.0. Detection follows the default branch, so the badge on the repo stays Other until then. Pullfrog already saw AGPL-3.0 on the PR head.

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Documentation
    • Added licensing information describing the repository’s AGPL-3.0-or-later terms, including the source-offer requirement for modified network services and the distinction from the separate Keepfolio product.
    • Updated the README with a licensing link, a description of the project, and clarifications that it makes no return claims and does not provide financial advice.
    • The GNU AGPL v3 license text remains in LICENSE; the project-specific notice and accompanying terms were removed from its opening.

GitHub licensee scored LICENSE as Other because a copyright grant
preceded the AGPL text. Move that grant into LICENSING.md unchanged,
and add a plain-language hook, a free-versus-Keepfolio note, and a
no-return-claims disclaimer for the YouTube pitch.

Co-authored-by: Ossie Irondi <AojdevStudio@users.noreply.github.com>
@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with docs:, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@cursor
cursor Bot enabled auto-merge (squash) October 9, 2026 22:37
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fdbb9571-bffe-4eef-a441-b7edd0535760

📥 Commits

Reviewing files that changed from the base of the PR and between a81bcd7 and 08c01d7.


📒 Files selected for processing (4)
  • LICENSE
  • LICENSING.md
  • README.md
  • pyproject.toml

 _______________________________________________________
< I raised 60 million carrots in my last funding round. >
 -------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The vendor backlink check links the first prose mention of each
vendor in README.md. The new hook is that first mention.

Co-authored-by: Ossie Irondi <AojdevStudio@users.noreply.github.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The license detection fix works, but relocating the program notice drops it from Python wheel distributions. Preserve that notice in the package before merging.

Reviewed changes across the license files and README, including GitHub license detection and a targeted wheel build.

  • License detection: Removes the project-specific prefix from LICENSE and preserves its copyright/grant in LICENSING.md; GitHub's API detects this head as AGPL-3.0.
  • Licensing explanation: Documents the complete free engine, AGPL network-source requirement, separate Keepfolio product, and bring-your-own provider accounts.
  • README positioning: Adds the self-hosted audience and pricing pitch, harness links, licensing navigation, demo-replacement TODO, and revised financial disclaimer.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6.1-sol | 𝕏

Comment thread LICENSING.md
Hatchling's default license globs skip LICENSING.md, so the grant
moved out of LICENSE was missing from the built package.

Co-authored-by: Ossie Irondi <AojdevStudio@users.noreply.github.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes since the previous Pullfrog review at d32e28d, focused on the packaging fix in 08c01d7.

  • Declared legal files: Added explicit license-files entries for LICENSE and LICENSING.md, preserving the relocated copyright and license grant in wheel distributions.
  • Verified distribution contents: Built the wheel and confirmed both legal files match their sources byte-for-byte and appear in its License-File metadata. Validation was targeted to packaging; the full Python test suite was not run.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@cursor
cursor Bot merged commit 70016d5 into main Oct 9, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants