Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: toggles on primary window #65

Open
huyz opened this issue Mar 31, 2024 · 9 comments
Open

[feature]: toggles on primary window #65

huyz opened this issue Mar 31, 2024 · 9 comments
Assignees
Labels
improvement New feature or request

Comments

@huyz
Copy link

huyz commented Mar 31, 2024

Proposal

Instead of making the user go into the settings to toggle which items to show, how about putting the toggles at the bottom of the window?

There's lots of room next to the Keyclu on the bottom-left for example.

I'm thinking of these toggles primarily:

  • Show bookmarks
  • Show user-hidden menu items
  • Show inactive menu items

Maybe even (but less important):

  • My shortcuts
  • macOS Keyboard Shortcuts

But I'm also thinking of another toggle, which I'll create a separate Feature Request #66 for:

  • Show menu items with no assigned shortcut (this is to make use of the very convenient CustomShortcuts functionality)

The toggles could take the form of checkboxes or could be of the form of button toggles; e.g.
screenshot 2024-04-26T083837Z@2x
(Source)

Thanks for considering.

Alternatives

Just have to go into the Settings to toggle things on and off.

@Anze
Copy link
Owner

Anze commented Mar 31, 2024

Hey huyz,
Thanks for the proposal. I hadn't considered that people might change those options frequently, as typically, once you set up an app, you don't tend to tinker with it unless there's a special occasion. I might add such options at some point in the future.

@huyz
Copy link
Author

huyz commented Apr 26, 2024

The toggles could take the form of checkboxes or could be of the form of button toggles; e.g.
screenshot 2024-04-26T083837Z@2x
(Source)

@Anze
Copy link
Owner

Anze commented Apr 26, 2024

I was trying out some switch/toggle icons to see how they'd look, but I realized that I don't have enough clear images for the indicating states of the options. I want to avoid using a word option with just a checkmark, as it doesn't fit with a modern UI.
This example demonstrates the issue I'm facing. Can you easily tell what each option would do?
Screenshot 2024-04-26 at 22 40 24

@Anze Anze moved this to Todo in KeyClu Roadmap Apr 26, 2024
@huyz
Copy link
Author

huyz commented Apr 27, 2024

I can't tell the other 3. Here are some ideas:

But the right choice probably isn't critical, as long as mouse-hover tooltips work, which is what I would rely on. Then I'd eventually learn which icon is what. And I don't expect to be toggling all of them a lot. Maybe just one or two.

I'm sure over time, you'll find better icons and can replace them.

@Anze
Copy link
Owner

Anze commented Apr 27, 2024

So you've got just about one bookmark — well, almost. It essentially toggles the display of bookmarked items as a group (#68). I aimed to stick to the icons available in SF Symbols.
Regarding tooltips, there's a hiccup preventing tooltips from appearing in certain cases.
I'll explore the possibility of including some essential switches into the command bar for the next release.

@Anze Anze self-assigned this Oct 5, 2024
@Anze Anze moved this from Todo to In Progress in KeyClu Roadmap Oct 14, 2024
@Anze Anze moved this from In Progress to Done in KeyClu Roadmap Oct 20, 2024
@Anze
Copy link
Owner

Anze commented Oct 31, 2024

Hey huyz,
I've just released a new version. Would love to hear your thoughts.

@huyz
Copy link
Author

huyz commented Nov 22, 2024

Works great for my use case, which is mainly about being able to add shortcuts to menu items that don't have shortcuts.

Thanks @Anze for implementing this.

It's a bit hard to tell what the icons do. Here are some suggestions that might help:

  • Adding tooltips if possible—I know that can be hard depending on the APIs. Or maybe briefly display some text when we toggle.
  • I don't understand what happens when I toggle: a key combo is displayed but I'm not sure what that is. Here, some text would help as well.
  • I wouldn't mind if the bottom bar were larger so that the icons were larger.
  • I feel like the ⌘ icon would be more obvious as a "right-panel" icon: https://thenounproject.com/icon/sidebar-6450283/
  • Playing around I can figure out what I and H stand for, but I still can't figure out what K is for.

@Anze
Copy link
Owner

Anze commented Nov 22, 2024

Hey huyz,
Thanks for the feedback! I'll definitely keep your suggestions in mind.
Here is the idea behind the toggles:
K - My (Custom) Shortcuts (stands for KeyClu)
- Apple Hotkeys
I - inactive menus
H - hidden menus
I agree it could be more clear. Thanks again for sharing your thoughts!

As for the symbols briefly displayed during toggling, they are just an attempt to make the loading more fun. Currently, those combinations don't mean anything, but might be real ones in the future.

@huyz
Copy link
Author

huyz commented Nov 23, 2024

Here's another suggestion that would help make things less confusing as well as automatically teaching us the meaning of K, H, I:

Only show each icon if the user has added at least one custom shortcuts (K) and hidden at least one menu entry (H). If I ever did that, I'd notice that the icon had appeared soon after I created one of those and I'd be able to guess what the icons mean.

For I, only show it if there is at least one inactive menu item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants