Project maintenance status?

[ccoVeille]

Hi @Antonboom

I'm sending a message in a bottle again as I did 6 months ago with

• Are you OK and safe Anton? #172

There are blocking issues that need to be fixed (= the linter can break code)

• Bad suggested fix for negative-positive #210 (hi @denik 👋)
• formatter: warn on msgAndArgs when msg is not of string type #202

And a few false-positive that could be fixed:

• error-is-as: ErrorAs warning when using generic target #213 (hi @uudashr 👋)
• false positive on expected-actual #174 (hi @mmorel-35 👋)

Some improvement that should be considered:

• Detect and warn on zero delta/epison values in InDelta/InEpsilon #211 (hi @oschwald 👋)
• formatter: remove empty message string in assert.Equalf conversions (autofix) #194 (hi @ghouscht 👋)
• formatter: warn on non-string the first single argument #201
• empty: add Equal empty string #119
• error-is-as: support assert.NotErrorAs #13

I provided a fix for #210 one month ago with

• fix: negative positive with type conversion #212 and I'm waiting for feedback from you.

I opened a PR more than 8 months ago to address #119

• empty: detect more cases #129

And I got no feedbacks at all.

There are also a few PRs where I think their author silent quitted because of the lack of reactivity:

• new checker http-const #155
• doc: update error-compare and define unwrapped-error #162

@Antonboom your GitHub timeline is pretty flat compared to the past.

So I'm asking, are you still maintaining the project?

• if yes, then do it
• if you need help, would you agree to grant me as a maintainer? I could work with @mmorel-35

If I don't have a clear response in the next month, I will maintain my fork of your project and start to maintain it. At some point, I might have to ask @ldez if he agrees to switch to my fork for golangci-lint.

https://github.com/ccoVeille/testifylint

I don't do it for ego, but because this project deserves to be maintained.

Respectfully,

Christophe

[ldez]

Anton is an important member of the golangci-lint community, I contacted him privately, and I will not take any decision before receiving direct feedback from him.

[ccoVeille]

I'm not convinced by the current project status

@ldez Do not hesitate to contact @mmorel-35 or myself in a few months.

[Antonboom]

Hi, everyone

are you still maintaining the project?

Yes. Otherwise it was archived or I notified about it 👌

if yes, then do it

I have in the plans to work on v1.6.0 (next milestone), but I don't give any SLO and do not see the reasons to push me or ask me explanations 🤔

if you need help, would you agree to grant me as a maintainer?

The testifylint is not "easy-to-made" project. Almost any checker requires a deep investigation, conversation with testify maintainers, reading and writing documentation, covering of corner cases, deep testing, etc. Unfortunately, at this point you have not demonstrated a sufficient level of expertise to be maintainers. But I do not rule this out in the future 💪

If I don't have a clear response in the next month, I will maintain my fork of your project and start to maintain it

You are welcome, but in any case I do not support the ultimatum form of conversation. If you want to find a place to direct your resources, I recommend forking testify itself and starting development of v2. Especially since its maintainers are not against it. It will bring much more benefit 🚀

have to ask @ldez if he agrees to switch to my fork for golangci-lint.

You can try, but I don't see any reason for that. Most of the issues in the testifylint are feature requests created by me. And I fix critical bugs or any blockers for golangci-lint almost instantly 😎

There are also a few PRs where I think their author silent quitted because of the lack of reactivity:

It was your choice to close these PRs, not my. I have plan to review it and reuse some code anyway. The reasons why it cannot be quickly I described above. I can't stop you from trying to contribute, but I can't promise a reactive response either (as I said above, like most maintainers of complex projects doing this in their free time, I don't give any SLOs. Look at the same testify a couple of years ago) 🤷‍♂️

Also you can choose the simplest issues and try to implement them, gradually increasing the complexity. I see no reason to be blocked by my answer in PR, since in any case everything will be thoroughly checked, and the code will be reused if it makes sense 👍

[ccoVeille]

Your style is intact 🤣.

So consistent with the experience I had with working with you.

So I'll assume you are fine.

Let's hope this project will find a maintainer.