Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Stopping a container inefficiently requires starting one. #167

Open
ScottBailey opened this issue May 15, 2023 · 2 comments
Open

Stopping a container inefficiently requires starting one. #167

ScottBailey opened this issue May 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working 👍 lgtm
Milestone

Comments

@ScottBailey
Copy link
Contributor

dunes --destroy-container will start a container before destroying one. This is very inefficient and, if the container has become corrupt, frustrating!

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog May 15, 2023
@stephenpdeos stephenpdeos added bug Something isn't working 👍 lgtm and removed triage labels May 24, 2023
@stephenpdeos stephenpdeos added this to the DUNE 1.3.0 milestone May 24, 2023
@stephenpdeos
Copy link
Member

stephenpdeos commented May 24, 2023

Many arguments do not require a running container (e.g. --version), however, the architecture currently requires one for member function calls. This can be fixed by converting the member functions into statics and calling them without creating the container. See --help for an example of a call that does not create a container.

  • Propose list of arguments that should not require a container to review with team
  • Make updates to have these arguments no longer be dependent on the existence of a container

@ScottBailey
Copy link
Contributor Author

Right now, the dunes::docker object starts the container in init(). Instead, I think we should add some support functions to determine the container state (e.g. is_running(), is_exited(), is_stopped(), etc, ???) and some additional functions to control that state (e.g. start(), stop(), destroy()).

This was referenced Jun 20, 2023
@ScottBailey ScottBailey self-assigned this Jun 21, 2023
@bhazzard bhazzard moved this from Todo to Icebox in Team Backlog Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
Development

No branches or pull requests

3 participants