Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #42

Open
3 tasks
AnidemDex opened this issue Oct 4, 2021 · 9 comments
Open
3 tasks

New features #42

AnidemDex opened this issue Oct 4, 2021 · 9 comments
Labels
discussion enhancement New feature or request help wanted Extra attention is needed

Comments

@AnidemDex
Copy link
Owner

AnidemDex commented Oct 4, 2021

Just an issue to discuss and keep track of new features planned or that could be cool to be included in the plugin.
Gonna open https://github.com/AnidemDex/Godot-DialogPlugin/discussions/ if I see that'll be something necessary (and will note every idea from discord).

None of those ideas will be included in the plugin until someone needs it, and a related issue about the implementation of that specific feature will be created.

not to fix an existing problem, just to add new problems to the road 🤪 /j

New features

Write based (script-like) timelines

  • Write based (script-like) timelines:

Something like:

[CharacterJoin GodoBot]
GodoBot: Oh, hi mark!

[EmitSignal "do_this"]

[CharacterJoin Godette]
[ChangeExpression Godette "Anger"]
Godette: Do you have to make the same joke everytime we meet?
 ...

Why?

Because we can! Sometimes is easier to keep and mantain timelines this way, feels more natural than making it through the timeline editor

How?

With dark magic Resources can be imported in many ways. Actually, timeline resources are text-based resources, saved as a Godot Text-Based Resource (*.tres) resource. You can tell Godot what and how can it import (literally) any file with any extension (dealing with the FormatLoader/Saver).

ChoiceEvent Yarnn-Spinner like

  • ChoiceEvent Yarnn-Spinner like.

Do you know nights in the woods? Well, that game have an amazing choice system that I want to replicate (since Yarn Spinner is a Unity thing).
image

Here's a link to the repository https://github.com/YarnSpinnerTool/YarnEditor
Note that I don't want to steal that choices idea and say "Hey, I made this, so it's MINE". Steal is bad. I just liked the design of the spinnable choices and want to replicate it.

Edit: Someone managed to use Yarnn in Godot (https://github.com/kyperbelt/GDYarn)

Compatibility with other text-script based formats or other plugins in timelines

  • Compatibility with other text-script based formats or other plugins in timelines

Do you know ink? What about renpy? Scrips made in json?
What if we read those formats and transform them into a timeline usable by this plugin? We're using Godot Resource, sure we can do that! Take a look to write-based timelines.

Video tutorials

I have no idea about video editing or about being a celebrity on internet, but video resources about how to use the plugin and where can be implemented is not a bad idea.

@AnidemDex AnidemDex added discussion enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2021
@AnidemDex AnidemDex pinned this issue Oct 4, 2021
@AnidemDex
Copy link
Owner Author

Update: Hey, @kyperbelt managed to integrate Yarnn to Godot. Take a look here https://github.com/kyperbelt/GDYarn

We will need to contact him in the future to integrate its stuff

@Jeremi360

This comment has been minimized.

@AnidemDex

This comment has been minimized.

@AnidemDex
Copy link
Owner Author

@Jeremi360 are you still interested on your idea? I'm curious about what happened

@Jeremi360
Copy link

Jeremi360 commented Dec 21, 2021

@Jeremi360 are you still interested on your idea? I'm curious about what happened

You surprised me a bit with your answer and I got a bit scared 😅
Yes, I'm still interested on my idea of joining forces.
I just see that there are many projects for Godot that are Dialog Systems,
on most of them work one person or in better scenarios few people.
So I thought it would be better to combine these projects, efforts and experience into one project.
Now Rakugo is becoming modular, collection of plugins,
so everyone can add something from each other in a flexible way, how about that?
Now only @TheLudovyc and me are working on Rakugo.

@Jeremi360

This comment has been minimized.

@AnidemDex
Copy link
Owner Author

@Jeremi360 for now, I'm still working on this plugin. When I saw a feature that can be integrated in rakugo, I'll try to do it. Take a look at EventSystem, maybe that can be useful there.

@Jeremi360
Copy link

@Jeremi360 for now, I'm still working on this plugin. When I saw a feature that can be integrated in rakugo, I'll try to do it. Take a look at EventSystem, maybe that can be useful there.

Okay, I see. I will look at your EventSystem.
How you made that you can connect different scripting ways of dialogues ?

@AnidemDex

This comment has been minimized.

AnidemDex added a commit that referenced this issue Mar 23, 2022
925dfe8 Update plugin.cfg
5405e5f Update event_class.gd
1592019 Revert 5dcc0b866017de0282047969d5ef9191fc643da2 .
a24ad35 Update EventManager and EventClass.
d110826 Merge pull request #50 from AnidemDex/event-class-improvement
d8b5505 Register EventGoTo
8a234f6 Verify that next event doesn't make cross references.
b6b2257 Add EventGoto
d562f17 Deprecate EventJumpToEvent
c2a0dc8 Deprecate EventChangeTimeline
c150c61 Fix events being overwrited on add_event.
47d54d4 Configure TimelineEditor.
4fa21ac Add a button on EventNode class.
0200c81 Add Event EditorInspectorPlugin.
18d64b2 Remove old welcome node script and scene
3659eba Remove old event node scene
c7d4c56 Remove unused editor script
8da1f32 Merge pull request #48 from AnidemDex/make-end-timeline-tool
746af52 Merge pull request #47 from AnidemDex/fix-shortcuts
1c144ee Fix shortcut not working.
40fe89a Add `tool` in EventEndTimeline.
cd2db08 Re-add welcome popup.
047f536 Rebuild plugin script base.
a4cbadf Add GodotPlugin class script.
49bb7d6 Fix an issue with old history
b978234 Update EventManager behaviour
b66c007 Update timeline save behaviour.
93c3360 Add set/get methods for next event in Event
103707a Add `next_event` property to Event class.
a937c94 Deprecate more timeline members.
5265ff2 Deprecate timeline members.
cb9a17b Merge pull request #42 from AnidemDex/event-container
b08b958 Restore old condition
463e4d2 Make timeline drawer a tool script
084a0d8 Remove old and now unused files.
e9a9c1c fix a method call on external data save
fadb534 avoid a warning related to shortcuts
3a8af8d Integrate the new editor into the plugin.
3d69132 Re-add editor toolbar.
baee833 Update registered_events script.
5cc7031 remove debug theme
b4e2d04 Update editor theme.
629c27c Make drag&drop work in subtimelines.
f38cd8c Improve drag and drop in subtimelines
9802e89 Re-enable drag and drop functionality.
ac9814c Split EventNode in pieces.
61fcf59 Backup before reset!
1999afc Improve theme
acf0ddf Improve timeline loading generation.\n Now with subevents and subtimelines
4adbd99 Idk what I did
7ee730d Rename classes
5b63fbc Add a lot of things. Don't forget to reacomodate the git story!!!
4367c2d Remove old theme pieces
94438df Update event node class
abb84e3 Add new condition event
12f9bc5 Merge pull request #39 from Crystalwarrior/fix-#23
1fd0d46 Merge pull request #40 from Crystalwarrior/fix-dragndrop
66d7c54 Fix timeline preview pop up not filling the horizontal space Make it resizable
f1502c9 Fix duplication bug when drag&dropping Fix drag preview being of the wrong node
c4b78a0 Fix odd drag and drop behavior, being unintuitive and causing user to lose events by accident
9c920e3 Fix events failing to save when edited in timeline unless a new event was created/removed Fix conditional event failing to save subresources unless main timeline is saved
dda3a87 Merge pull request #36 from Crystalwarrior/fix-35
5891f55 Rename return.gd to end_timeline.gd
6c5716b Fix AnidemDex/Godot-EventSystem#35
1319d33 Add return event
e48d888 Update plugin version
6b4d3ec Update timeline class
7abd72e Update plugin.cfg
e487758 Make event set extends from EventCallFrom.
3427cce Make EventCallFrom default EventCall event.
d40f7ad Make timeline the default value for EventManager node.timeline
42d6270 fix an issue related to editing an array in event
5c151f2 Unlock the full power of wait timer by removing arbitrary limitations (60 seconds only, 1 second step only)
43c8725 Add Call From event
62b3caa Update plugin version
cdc4eb9 Make EventManager a tool script
4ad9164 Hide scripts from editor
70f028c Update event manager class.
6c583fe Update event class. Now it defers the call to `_execute` method
d370f8d Update plugin.cfg
e76bfdf Add default names to condition timelines.
0d050e3 Add recent timelines icon
4f4500d Add a callback to automatically clear history
fdac7bd Add timeline history to timeline editor scene.
0c7b5da Add the plugin to editor meta and creates a function to register new events
ac48bb6 Fix version button
15bb931 Merge pull request #13 from AnidemDex/feature/timeline_name
d0e9cc1 Add resource_name next to resource_path in timeline editor
3229823 Update change timeline event
fa4a0e0 Update event inspector to ignore ignored properties
6f7783e Update plugin script to register event inspector
2036102 Add event inspector.
887ca48 Add inspector tools.
06d44be Merge branch 'main' of https://github.com/AnidemDex/Godot-EventSystem
05a8122 Fix a bug related to sub-classes of a class that extends Event
d83cbea Update plugin.cfg
2bba794 Add class name to call event
23347fc Register call event
184153c Add call event.
f017dd6 Add event icon
5ab11b6 Update emit signal event category
02bf721 Update emit signal event color
904182c Add class names to new events
f4616a1 Update new events
5c797b7 Add new event icons.
86b5276 Update registered_events.tres
2e7a71c Add show node event.
5252e35 Add hide node event.
f597b65 Add icon import file to avoid recreating it in playground
debcb08 Fix event Jump To.
6f3186e Add plugin icon
1443a30 Add a lot of stuff.
a97cc7e Add assets
92139ac Add license file inside the plugin folder
ba80f61 Update plugin script
5918e7d Add timeline editor themes
da22b79 Update EventTimelineEditor.
a817fad Update timeline class.
394602b Add `tool` to plugin scripts.
90747da Update TimelineEditor
40ea0ca Add registered events resource
d8a856e Update Timeline class
a5ac71f Add TimelineDisplayer
72b7ecc Update EventNode
531d710 Add Category and CategoryManager
ae993c1 Add Comment event
4f40ea9 Update EventClass
7839ddb Update EventNode
ad263de Add EventNode
9811c84 Update event class
09341f3 Update event manager
fc8d1f0 Add Timeline and EventManager
8337f0d Remove scripts and start again
d90386d Add Timeline class
a73a626 Rename EventResource to Event
cb5967c Update EventPlayer
c4ab400 Add EventPlayer class
60d6d16 Add EventNode class script
6ea204d add event class script
5b5fc7e update plugin script
eeab5f7 first commit
REVERT: 02ad072 Add Event: CallFrom [PR #18] from joaopedrosgs/add-call-from

git-subtree-dir: addons/event_system_plugin
git-subtree-split: 925dfe813420e808fbf85b73eca29eac490d27cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants