Slow account creation

[AndreMiras]

Yes "slow" is relative. But it feels like on other Android applications the account creation is almost instant.
They may have decreased the pbkdf2 iterations, but I don't think as much as we did. Also it's easy enough to verify just by reading the keystore json. I also don't think they perform the creation on a remote server, but on the device just like we do.
Here are the upstream tickets:

• Account generation speed and installation ethereum/pyethereum#750
• Slow account creation ethereum/pyethapp#292

[AndreMiras]

I didn't get a chance to investigate more, but also for account loading/decrypting, w3.eth.account.decrypt() from python web3 (https://github.com/ethereum/web3.py/blob/v4.0.0-beta.13/docs/web3.eth.account.rst) is way faster than pyethapp.accounts.Account.load(wallet_path, password=password). So fixing it in pyethapp/pyethereum might be just as simple as using the same module as the one web3 uses.

[AndreMiras]

Upstream pull request that fixes the issue ethereum/pyethapp#293.
I'll probably monkey patch and back port it to PyWallet.