From d1fb2de4844d020a5fa3a17609432f79ef544897 Mon Sep 17 00:00:00 2001
From: Jam Balaya <jambalaya.pyoncafe@outlook.jp>
Date: Wed, 24 Jun 2026 12:47:16 +0900
Subject: [PATCH] fix(which): respect prefer_offline so binary lookup avoids
 remote fetches (#10595)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
---
 e2e/cli/test_which_prefer_offline | 72 +++++++++++++++++++++++++++++++
 settings.toml                     |  2 +-
 src/env.rs                        |  1 +
 3 files changed, 74 insertions(+), 1 deletion(-)
 create mode 100644 e2e/cli/test_which_prefer_offline

diff --git a/e2e/cli/test_which_prefer_offline b/e2e/cli/test_which_prefer_offline
new file mode 100644
index 0000000000..65dc0e50f3
--- /dev/null
+++ b/e2e/cli/test_which_prefer_offline
@@ -0,0 +1,72 @@
+#!/usr/bin/env bash
+
+# Regression test for https://github.com/jdx/mise/discussions/10460
+#
+# `mise which` is a binary lookup and must not require HTTP calls when an
+# installed version already satisfies the request. It is now in the
+# prefer-offline auto-enable list (like `where`, `ls`, `exec`), so even an
+# explicit `minimum_release_age` cutoff -- which normally forces date-aware
+# remote resolution on regular commands -- must keep resolving from installed
+# versions instead of fetching a remote version list.
+#
+# Scope: this covers config-file tools. An explicit `--tool=spy@1` argument is
+# a `ToolSource::Argument` request, which intentionally opts out of
+# prefer-offline so explicit version requests resolve accurately (see #10571),
+# consistent with `mise exec`/`mise x`; that path is not exercised here.
+
+# Copy the dummy plugin into one whose remote version-listing scripts leave a
+# marker file behind when they run, making any remote fetch directly
+# observable. (cat > preserves the executable bit from the copied scripts.)
+marker="$HOME/remote-versions-fetched"
+cp -RL "$MISE_DATA_DIR/plugins/dummy" "$MISE_DATA_DIR/plugins/spy"
+cat >"$MISE_DATA_DIR/plugins/spy/bin/list-all" <<EOF
+#!/usr/bin/env bash
+touch "$marker"
+echo "1.0.0 1.1.0 2.0.0"
+EOF
+cat >"$MISE_DATA_DIR/plugins/spy/bin/latest-stable" <<EOF
+#!/usr/bin/env bash
+touch "$marker"
+echo "2.0.0"
+EOF
+
+mise install spy@1.0.0
+
+# Drop the marker and the remote-versions cache written during install. The
+# cache must go too: a regressed which with a warm cache would resolve
+# remotely without re-running list-all, hiding the fetch from the marker.
+rm -f "$marker"
+rm -rf "$MISE_CACHE_DIR/spy"
+
+# Fuzzy requests ("latest", a prefix) are the dangerous ones: an explicit
+# cutoff pushes those onto the remote date-aware resolution path. Newer remote
+# versions (1.1.0, 2.0.0) exist, so a regressed remote resolution would also
+# report a non-installed version below. Test both with no cutoff (built-in
+# default) and an explicit cutoff.
+for mra in unset 24h; do
+  if [[ $mra == unset ]]; then
+    unset MISE_MINIMUM_RELEASE_AGE
+  else
+    export MISE_MINIMUM_RELEASE_AGE="$mra"
+  fi
+
+  for version in latest 1 1.0.0; do
+    cat >mise.toml <<EOF
+[tools]
+spy = "$version"
+EOF
+
+    # The spy plugin installs a bin named `dummy`; look it up and assert it
+    # resolved to the installed 1.0.0 without a remote fetch. Check the
+    # resolved version (not the path, whose dir mirrors the request string
+    # "1"/"latest") so the assert is request-independent. A regressed remote
+    # resolution would pick a newer non-installed version (1.1.0/2.0.0) and
+    # `mise which` would fail to find the bin.
+    resolved="$(mise which --version dummy)" || fail "mise which dummy failed for spy@$version"
+
+    if [[ -e $marker ]]; then
+      fail "mise which fetched remote versions resolving spy@$version (minimum_release_age=$mra)"
+    fi
+    assert_contains_text "$resolved" "1.0.0"
+  done
+done
diff --git a/settings.toml b/settings.toml
index cd77069399..3880959c28 100644
--- a/settings.toml
+++ b/settings.toml
@@ -1852,7 +1852,7 @@ When enabled, mise will prefer locally cached data and avoid remote version fetc
 possible. Unlike `offline`, this still allows network requests as a fallback.
 
 This is automatically enabled for fast commands like `hook-env`, `activate`, `exec`, `env`,
-`ls`, `current`, `where`, and shims.
+`ls`, `current`, `where`, `which`, and shims.
 """
 env = "MISE_PREFER_OFFLINE"
 type = "Bool"
diff --git a/src/env.rs b/src/env.rs
index a30cf2a91d..5ebc74e11e 100644
--- a/src/env.rs
+++ b/src/env.rs
@@ -694,6 +694,7 @@ fn prefer_offline(args: &[String]) -> bool {
                 "hook-env",
                 "ls",
                 "where",
+                "which",
                 "x",
             ]
             .contains(&a.as_str())