Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update apptable to support Lang element to display when there is no data #2950

Open
wants to merge 4 commits into
base: feature/signing
Choose a base branch
from

Conversation

HauklandJ
Copy link
Contributor

@HauklandJ HauklandJ commented Jan 27, 2025

Description

Update AppTable to support Lang element to display when there is no data.

Use this in SigneeList to show a fallback if there is not data supplied from ISigneeProvider in the BE.

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@HauklandJ HauklandJ added the kind/product-feature Pull requests containing new features label Jan 27, 2025
@HauklandJ HauklandJ self-assigned this Jan 27, 2025
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌 som sagt så tror jeg cypress-testene feiler pga at branchen ikke har nyeste main. Kan merge inn main i feature/signing og så kan du merge inn derfra?

src/language/texts/nn.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

2 participants