Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens: Set values for font-size and line-height globally #76

Open
1 of 2 tasks
haakemon opened this issue Aug 2, 2022 · 0 comments
Open
1 of 2 tasks

Tokens: Set values for font-size and line-height globally #76

haakemon opened this issue Aug 2, 2022 · 0 comments

Comments

@haakemon
Copy link
Contributor

haakemon commented Aug 2, 2022

Description

We are missing tokens for font-size and line-height for TextField component.

When using the component in app-frontend, everything looks fine, because of some global styles that are set that targets input elements.

In Storybook however, we set no such global styles, and rely only on browser defaults. Because of this, the component looks a bit different in Storybook:
image
vs app-frontend:
image

Ref: #61 (comment)

Additional Information

No response

Tasks

We need figma tokens for font-size and line-height, or decide that these values are somethign we should set globally, and inherit down to f.ex input. These values can then be added from our AppWrapper component.

  • Add tokens specific for TextField component (and other components that need font size/line-height)
    OR
  • Set these values globally

Tokens

component.input.size.min_height.default
component.input.font_size.default

Acceptance Criterias

No response

@haakemon haakemon mentioned this issue Aug 2, 2022
4 tasks
@mrosvik mrosvik moved this to 🔖 Prioritized in Team Design System Jan 4, 2023
@mrosvik mrosvik moved this from 🔖 Prioritized to 📋 Backlog in Team Design System Jan 4, 2023
@mrosvik mrosvik changed the title TextField font size and line-height, missing tokens Token Issue: Set values for font-size and line-height globally Jan 4, 2023
@mrosvik mrosvik changed the title Token Issue: Set values for font-size and line-height globally Tokens: Set values for font-size and line-height globally Jan 4, 2023
@mrosvik mrosvik removed their assignment Jan 4, 2023
@mrosvik mrosvik moved this from 📋 Backlog (Design) to 📋 Backlog (Development) in Team Design System Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants