Skip to content

Commit 636b326

Browse files
committed
fix: handle --limit 0 for schema inspection and safe dispose() cleanup
- `--limit 0` now correctly calls `immediatelyExecuteSQLWithLimit` (valid for schema inspection) - `--limit foo` (NaN) is rejected and falls through to unlimited execution - Wrap `adapter.dispose()` in try-catch to prevent masking command errors
1 parent 40399d0 commit 636b326

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/dbt-tools/src/commands/execute.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ export async function execute(adapter: DBTProjectIntegrationAdapter, args: strin
55
if (!sql) return { error: "Missing --query" }
66
const model = flag(args, "model") ?? ""
77
const raw = flag(args, "limit")
8-
const limit = raw ? parseInt(raw, 10) : undefined
9-
if (limit) return adapter.immediatelyExecuteSQLWithLimit(sql, model, limit)
8+
const limit = raw !== undefined ? parseInt(raw, 10) : undefined
9+
if (limit !== undefined && !Number.isNaN(limit)) return adapter.immediatelyExecuteSQLWithLimit(sql, model, limit)
1010
return adapter.immediatelyExecuteSQL(sql, model)
1111
}
1212

packages/dbt-tools/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ async function main() {
187187
result = { error: `Unknown command: ${cmd}`, usage: USAGE }
188188
}
189189
} finally {
190-
await adapter.dispose()
190+
try { await adapter.dispose() } catch {}
191191
}
192192

193193
return result

0 commit comments

Comments
 (0)