UI/daily task/feature/daily task progress popup #405
Merged
+2,299
−585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srbackman
commented
Feb 12, 2025
srbackman
commented
- When ever progress is made towards a task a small popup window will appear from left side to display the current tasks progress (note! if the popup just was on the screen and task is completed, it wont show the rewards popup).
- Removed unused "using" statements in DailyQuest.cs and DailyTaskProgressManager.cs.
- Commented a clan data saving section in DailyTaskProgressManager.cs due to it not working properly at the moment.
BillTheBeast
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Siirrä toi progress popup osaksi UIOverlayPanelia, silloin se saadaan sopimaan kunnolla muuhun käyttöliittymään ja sen skaalaukseen. Kyllä tämä tarkoittaa tuon popupin koodin sijoittamista erilliseen skriptiin. Viestit Managerilta Popupille voidaan siirtää delegaattien/eventtien avulla.
Lisäksi suosittelen välttämään määrittelemään useampia muutujia samalla rivillä niin kuin ProgressManagerin rivillä 421 on tehty. Tuosta tulee helposti aika vaikea lukuista.
-When ever progress is made towards a task a small popup window will appear from left side to display the current tasks progress.
-DailyTask progress popup should now show the current task as done when task is done.
- Removed unused "using" statements in DailyQuest.cs and DailyTaskProgressManager.cs. - Added documentations to DailyTaskProgressManager.cs - Renamed a few variables regarding progress popup in DailyTaskProgressManager.cs - Commented a clan data saving section due it not working properly at the moment.
- DailyTask reward popup now shows the reward when the task is completed (note! if the popup just was on the screen and task is completed, it wont show the rewards popup).
- DailyTask progress popup code is now it's own class DailyTaskProgressPopup.cs. - Moved DT progress popup elements from "10-MenuUi" scene to "UIOverlayPanel" prefab.
srbackman
force-pushed
the
UI/DailyTask/feature/DailyTaskProgressPopup
branch
from
03fbd55 to
04bbf61
Compare
BillTheBeast
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.