-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You should be able to provide blank values to battlecharacter_id field. #434
Comments
If the When you are updating a player data, you do not have to specify this field (nor any of them except for Do you still need some other value of it as null or is the empty array ok? |
An empty array is fine but the real problem is if the player has partially filled array. I could make it so that the data isn't sent to server if one of them is empty, but it could feel cumbersome for the player if sometimes the changes don't save properly, in what they might percieve as "for no good reason". So yes, I could handle a lot of this clientside, but I just wanted to ask if inserting a incomplete list would be okay. |
It will be ok to insert only 0-3 characters. The validation is set so that this array can be up to 3 _ids. The only thing to notice is that, when you update player's |
Currently you cannot provide a "blank" value (0 or -1) to the battleCharacter_id.
Instead you need to provide a valid mangodp id to battleCharacter_id field.
These blank values are needed if the player hasn't set one of the characters in charactergallery to save the states of the gallery properly.
I can try to work around this if you don't want to change this.
What is the endpoint and method? (if applicable)
Endpoint: Player/
Method: PUT
What should it do instead?
If value is 0 or -1 it should be accepted as an empty value.
The text was updated successfully, but these errors were encountered: