Skip to content

Commit c3477bc

Browse files
committed
PICARD-1669: Use "unplated" taskbar icon for MSIX package
This will Windows use the unmodified Picard icon in the taskbar instead of automatically adding a padding and background. This does not affect the appearance of the start menu tiles. See https://docs.microsoft.com/en-us/windows/msix/desktop/desktop-to-uwp-manual-conversion#optional-add-target-based-unplated-assets
1 parent 7b7f709 commit c3477bc

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed
Loading
Loading

scripts/package/win-package-appx.ps1

+13-3
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,23 @@ ThrowOnExeError "setup.py build_ext -i failed"
2929
Write-Output "Building Windows installer..."
3030
pyinstaller --noconfirm --clean picard.spec 2>&1 | %{ "$_" }
3131
ThrowOnExeError "PyInstaller failed"
32-
FinalizePackage dist\picard
32+
$PackageDir = (Resolve-Path dist\picard)
33+
FinalizePackage $PackageDir
34+
35+
# Generate resource files
36+
Copy-Item appxmanifest.xml $PackageDir
37+
$PriConfigFile = (Join-Path (Resolve-Path .\build) priconfig.xml)
38+
Push-Location $PackageDir
39+
MakePri createconfig /ConfigXml $PriConfigFile /Default en-US /Overwrite
40+
ThrowOnExeError "MakePri createconfig failed"
41+
MakePri new /ProjectRoot $PackageDir /ConfigXml $PriConfigFile
42+
ThrowOnExeError "MakePri new failed"
43+
Pop-Location
3344

3445
# Generate msix package
3546
$PicardVersion = (python -c "import picard; print(picard.__version__)")
3647
$PackageFile = "dist\MusicBrainz Picard $PicardVersion.msix"
37-
Copy-Item appxmanifest.xml dist\picard
38-
MakeAppx pack /o /h SHA256 /d dist\picard\ /p $PackageFile
48+
MakeAppx pack /o /h SHA256 /d $PackageDir /p $PackageFile
3949
ThrowOnExeError "MakeAppx failed"
4050

4151
# Sign package

0 commit comments

Comments
 (0)