main -> dev

[ryzen-xp]

Summary by CodeRabbit

• New Features

  • Escrow vaults now support direct token withdrawals by vault owners
  • SDK now includes a transaction builder for constructing and submitting Soroban contract transactions, supporting registration, address management, and resolution operations

• Bug Fixes

  • Auction contract now prevents bidders from placing bids that would outbid their own previous positions

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c18b5b1c-91a8-441e-baaa-7d37d40f6263

📥 Commits

Reviewing files that changed from the base of the PR and between 1762037 and e8dc7f5.

⛔ Files ignored due to path filters (1)

• sdk/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (9)

• gateway-contract/contracts/auction_contract/src/errors.rs
• gateway-contract/contracts/auction_contract/src/lib.rs
• gateway-contract/contracts/auction_contract/src/test.rs
• gateway-contract/contracts/auction_contract/test_snapshots/test/test_create_auction_past_end_time_fails.1.json
• gateway-contract/contracts/auction_contract/test_snapshots/test/test_outbid_self_fails.1.json
• gateway-contract/contracts/escrow_contract/src/lib.rs
• gateway-contract/contracts/escrow_contract/src/test.rs
• sdk/src/__tests__/tx.test.ts
• sdk/src/tx.ts

---

📝 Walkthrough

Walkthrough

This PR adds self-bid rejection to the auction contract, introduces a withdrawal mechanism for the escrow contract, and implements a new StellarTxBuilder SDK class for constructing and submitting Stellar Soroban transactions, with corresponding tests and ledger snapshots.

Changes

Cohort / File(s)	Summary
Auction Self-Bid Prevention gateway-contract/contracts/auction_contract/src/errors.rs, gateway-contract/contracts/auction_contract/src/lib.rs, gateway-contract/contracts/auction_contract/src/test.rs, gateway-contract/contracts/auction_contract/test_snapshots/test/*	Added AuctionError::SelfBid = 10 error variant; place_bid now validates bidder is not the current highest bidder before processing; new test test_outbid_self_fails verifies rejection of self-outbids; ledger snapshots captured for test scenarios.
Escrow Withdrawal Feature gateway-contract/contracts/escrow_contract/src/lib.rs, gateway-contract/contracts/escrow_contract/src/test.rs	Added public withdraw(env, commitment, amount) method to enable vault owners to withdraw funds; removed debug logging from execute_scheduled; added tests for successful withdrawal and insufficient balance scenarios.
SDK StellarTxBuilder sdk/src/tx.ts, sdk/src/__tests__/tx.test.ts	Implemented StellarTxBuilder class with async builder methods (buildRegister, buildRegisterResolver, buildAddStellarAddress, buildResolve) and submitTransaction for constructing and submitting Stellar Soroban contract transactions; added integration test verifying XDR round-trip consistency.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related issues

• [Feature][SDK] Implement StellarTxBuilder — build Soroban transactions for register and resolve #198: Implements the StellarTxBuilder class with buildRegister, buildAddStellarAddress, buildResolve, and submitTransaction methods as described in the SDK feature request.
• bug: place_bid allows self-outbid #264: Directly implements the requested auction self-bid prevention: adding AuctionError::SelfBid variant, enforcing self-outbid rejection in place_bid, and adding corresponding test coverage.
• feat: add withdraw function to escrow #281: Matches the escrow contract enhancements with the new public withdraw method and validation tests.

Possibly related PRs

• chore(auction): place_bid allows self-outbid #327: Implements identical auction contract changes (AuctionError::SelfBid, self-outbid validation, and test snapshots).
• feat(zk-sdk): add StellarTxBuilder for Soroban register and resolve f… #229: Adds the same SDK files (sdk/src/tx.ts and sdk/src/tests/tx.test.ts) with StellarTxBuilder implementation.
• test(contract): Generate and Commit Soroban Snapshot Tests #256: Related through auction contract snapshot tracking; this PR's snapshots depend on snapshot file management enabled by that PR.

Suggested labels

Passed

Poem

🐰 A bidder tried to outbid their own stake,
But the contract said "no," for goodness' sake!
Escrow folk withdraw with measured grace,
And Stellar's builder keeps transactions in place! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}