test: add unit tests for mcp-config and detector modules (#5)

- Add 9 tests for mcp-config.ts (multi-IDE, edge cases, path validation)
- Add 1 test for detector.ts (checkAllDependencies integration)
- Improve coverage: detector.ts 3.27% → 68.85%, mcp-config.ts 24.34% → 33.55%
- Total tests: 128 → 138 (all passing)
- Update test summary in _bmad-output

Author: Alenryuichi

_bmad-output/implementation-artifacts/tests/test-summary.md

@@ -1,208 +1,99 @@
 # Test Automation Summary
 
 **Generated**: 2026-02-03
-**Project**: openmemory-plus CLI
 **Framework**: Vitest v4.0.18
+**Project**: openmemory-plus CLI
 
 ## Generated Tests
 
 ### Unit Tests
 
-| File | Tests | Status | Description |
-|------|-------|--------|-------------|
-| ✅ tests/platform.test.ts | 18 | NEW | Platform utilities - getPlatform, isTTY, isCI, safeExec, waitForService, isPortInUse |
-
-### Existing Tests
-
-| File | Tests | Status | Description |
-|------|-------|--------|-------------|
-| ✅ tests/decay.test.ts | 15 | Existing | Memory decay system |
-| ✅ tests/graph.test.ts | 12 | Existing | Graph memory system |
-| ✅ tests/deps.test.ts | 11 | Existing | Dependencies command |
-| ✅ tests/install.test.ts | 9 | Existing | Install command |
-| ✅ tests/status.test.ts | 9 | Existing | Status command |
-| ✅ tests/cli.test.ts | 7 | Existing | CLI entry point |
-| ✅ tests/doctor.test.ts | 6 | Existing | Doctor command |
-| ✅ tests/detector.test.ts | 6 | Existing | Dependency detector |
-
-## Coverage Report
-
-### Before QA Automation
-
-| Metric | Value |
-|--------|-------|
-| Statements | 16.08% |
-| Branches | 14.61% ❌ |
-| Functions | 25.66% |
-| Lines | 16.03% |
-
-### After QA Automation
-
-| Metric | Value | Change |
-|--------|-------|--------|
-| Statements | 21.87% | +5.79% |
-| Branches | 19.72% ✅ | +5.11% |
-| Functions | 38.05% | +12.39% |
-| Lines | 21.73% | +5.70% |
-
-### Module Coverage
-
-| Module | Statements | Branches | Status |
-|--------|------------|----------|--------|
-| src/lib/memory/ | 96.39% | 86.79% | ✅ Excellent |
-| src/lib/platform.ts | 75.00% | 56.41% | ✅ Good (NEW) |
-| src/commands/deps.ts | 17.90% | 16.17% | ⚠️ Needs more |
-| src/lib/detector.ts | 3.27% | 13.33% | 🔴 Low |
-| src/commands/ (others) | 0% | 0% | 🔴 Low |
+| File | Tests Added | Description |
+|------|-------------|-------------|
+| `tests/mcp-config.test.ts` | +9 | MCP configuration edge cases, multi-IDE support, path validation |
+| `tests/detector.test.ts` | +1 | checkAllDependencies integration test |
+
+### Test Details
+
+#### mcp-config.test.ts (New Tests)
+- [x] `checkMcpConfigured` - should return false for unknown IDE
+- [x] `configureMcpForIdes` - should configure multiple IDEs
+- [x] `configureMcpForIdes` - should handle mixed valid and invalid IDEs
+- [x] `IDE config paths` - should return correct path for cursor
+- [x] `IDE config paths` - should return correct path for claude (CLI)
+- [x] `IDE config paths` - should return correct path for claude-desktop on darwin
+- [x] `IDE config paths` - should return correct path for gemini on darwin
+- [x] `configureMcpForIde edge cases` - should handle invalid JSON in existing config
+- [x] `configureMcpForIde edge cases` - should create cursor config in correct location
+
+#### detector.test.ts (New Tests)
+- [x] `checkAllDependencies` - should return status for all dependencies
+
+## Coverage
+
+### Before
+| Module | Statements | Branches | Functions | Lines |
+|--------|------------|----------|-----------|-------|
+| All files | 23.12% | 22.74% | 36.00% | 22.99% |
+| detector.ts | 3.27% | 13.33% | 10.00% | 3.33% |
+| mcp-config.ts | 24.34% | 21.50% | 25.00% | 24.66% |
+
+### After
+| Module | Statements | Branches | Functions | Lines |
+|--------|------------|----------|-----------|-------|
+| All files | **27.67%** | **25.49%** | **45.33%** | **27.65%** |
+| detector.ts | **68.85%** | **44.44%** | **100%** | **70.00%** |
+| mcp-config.ts | **33.55%** | **25.80%** | **42.85%** | **34.00%** |
+
+### Improvement Summary
+- **Total coverage**: +4.55% (23.12% → 27.67%)
+- **detector.ts**: +65.58% (3.27% → 68.85%)
+- **mcp-config.ts**: +9.21% (24.34% → 33.55%)
+- **src/lib overall**: +16.21% (41.44% → 57.65%)
 
 ## Test Results
 
 ```
 ✓ tests/status.test.ts (9 tests)
 ✓ tests/doctor.test.ts (6 tests)
-✓ tests/detector.test.ts (6 tests)
+✓ tests/providers.test.ts (22 tests)
 ✓ tests/graph.test.ts (12 tests)
 ✓ tests/decay.test.ts (15 tests)
+✓ tests/mcp-config.test.ts (18 tests) ← +9 new
 ✓ tests/deps.test.ts (11 tests)
-✓ tests/platform.test.ts (18 tests) ← NEW
+✓ tests/detector.test.ts (7 tests) ← +1 new
+✓ tests/platform.test.ts (18 tests)
 ✓ tests/cli.test.ts (7 tests)
-✓ tests/install.test.ts (9 tests)
+✓ tests/install.test.ts (13 tests)
 
-Test Files: 9 passed (9)
-Tests: 93 passed (93)
-Duration: 2.35s
+Test Files: 11 passed
+Tests: 138 passed (was 128)
+Duration: ~114s
 ```
 
-## Key Achievements
-
-1. ✅ **Branch coverage threshold met**: 19.72% > 15% required
-2. ✅ **New test file created**: `platform.test.ts` with 18 tests
-3. ✅ **Platform utilities now tested**: getPlatform, isTTY, isCI, safeExec, waitForService, isPortInUse
-4. ✅ **All 93 tests passing**
-
 ## Next Steps
 
-1. Add more tests for `detector.ts` to improve coverage
-2. Add integration tests for command modules (install, status, doctor)
-3. Consider mocking external dependencies (Docker, Ollama) for isolated testing
-4. Set up CI/CD pipeline with test coverage gates
-
-## Commands
-
-```bash
-# Run all tests
-npm test
-
-# Run with coverage
-npm run test:coverage
-
-# Watch mode
-npm run test:watch
-```
+1. ✅ Run tests in CI (already configured in `prepublishOnly`)
+2. Consider adding more edge case tests for:
+   - `src/commands/install.ts` (0% coverage)
+   - `src/commands/status.ts` (0% coverage)
+   - `src/commands/doctor.ts` (0% coverage)
+3. Add E2E tests for full CLI workflow
+
+## Validation Checklist
+
+- [x] Tests use standard test framework APIs (Vitest)
+- [x] Tests cover happy path
+- [x] Tests cover error cases (invalid IDE, invalid JSON)
+- [x] All generated tests run successfully
+- [x] Tests use proper assertions
+- [x] Tests have clear descriptions
+- [x] No hardcoded waits or sleeps
+- [x] Tests are independent (no order dependency)
+- [x] Test summary created
+- [x] Tests saved to appropriate directories
+- [x] Summary includes coverage metrics
 
 ---
 
 **Done!** Tests generated and verified. ✅
-
-**项目**: openmemory-plus  
-**日期**: 2026-02-02  
-**测试框架**: Vitest v4.0.18  
-**执行模式**: YOLO (自动化)
-
----
-
-## 📊 测试结果
-
-| 指标 | 数值 |
-|------|------|
-| 测试文件 | 7 |
-| 测试用例 | 62 |
-| 通过 | 62 ✅ |
-| 失败 | 0 |
-| 执行时间 | ~2s |
-
----
-
-## 📁 Generated Tests
-
-### 新增测试文件
-
-| 文件 | 测试数 | 状态 |
-|------|--------|------|
-| `tests/doctor.test.ts` | 6 | ✅ 新增 |
-| `tests/status.test.ts` | 9 | ✅ 新增 |
-| `tests/cli.test.ts` | 7 | ✅ 新增 |
-
-### 现有测试文件
-
-| 文件 | 测试数 | 状态 |
-|------|--------|------|
-| `tests/detector.test.ts` | 6 | ✅ 通过 |
-| `tests/decay.test.ts` | 15 | ✅ 通过 |
-| `tests/graph.test.ts` | 12 | ✅ 通过 |
-| `tests/install.test.ts` | 7 | ✅ 通过 |
-
----
-
-## 📈 Coverage Report
-
-| 模块 | Statements | Branches | Functions | Lines |
-|------|------------|----------|-----------|-------|
-| **src/lib/memory** | 96.39% | 86.79% | 100% | 99.03% |
-| src/lib/memory/decay.ts | 97.22% | 96.15% | 100% | 97.14% |
-| src/lib/memory/graph.ts | 95.94% | 77.77% | 100% | 100% |
-| src/lib/memory/types.ts | 100% | 100% | 100% | 100% |
-| **src/lib** | 4.08% | 26.08% | 10% | 4.16% |
-| src/lib/detector.ts | 4.08% | 26.08% | 10% | 4.16% |
-| **src/commands** | 0% | 0% | 0% | 0% |
-| **Overall** | 24.88% | 26.94% | 39.34% | 24.64% |
-
-### 覆盖率说明
-
-- **Memory 模块**: 高覆盖率 (96%+)，核心逻辑已充分测试
-- **Commands 模块**: 低覆盖率，因为测试通过 CLI 集成测试而非单元测试
-- **Detector 模块**: 低覆盖率，因为依赖外部系统 (Docker, Ollama)
-
----
-
-## 🧪 测试类型
-
-### 单元测试
-- [x] `detector.test.ts` - 依赖检测逻辑
-- [x] `decay.test.ts` - 记忆衰减算法
-- [x] `graph.test.ts` - 知识图谱存储
-- [x] `doctor.test.ts` - 问题诊断逻辑
-- [x] `status.test.ts` - 状态格式化逻辑
-
-### 集成测试
-- [x] `install.test.ts` - 安装命令 E2E
-- [x] `cli.test.ts` - CLI 入口点 E2E
-
----
-
-## 🔧 运行命令
-
-```bash
-# 运行所有测试
-cd cli && npm test
-
-# 运行测试并生成覆盖率
-cd cli && npm run test:coverage
-
-# 监听模式
-cd cli && npm run test:watch
-```
-
----
-
-## 📋 Next Steps
-
-1. **提高 Commands 覆盖率**: 添加更多 mock 测试
-2. **添加 E2E 测试**: 测试完整用户流程
-3. **CI 集成**: 在 GitHub Actions 中运行测试
-4. **性能测试**: 测试大量记忆的处理性能
-
----
-
-*由 Quinn QA Automate 生成*
-

cli/tests/detector.test.ts

@@ -1,7 +1,26 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import { isSystemReady, type SystemStatus } from '../src/lib/detector.js';
+import { isSystemReady, checkAllDependencies, type SystemStatus } from '../src/lib/detector.js';
 
 describe('detector', () => {
+  describe('checkAllDependencies', () => {
+    it('should return status for all dependencies', async () => {
+      const status = await checkAllDependencies();
+
+      // Verify all dependency keys exist
+      expect(status).toHaveProperty('docker');
+      expect(status).toHaveProperty('ollama');
+      expect(status).toHaveProperty('qdrant');
+      expect(status).toHaveProperty('openmemory');
+      expect(status).toHaveProperty('bgeM3');
+
+      // Verify each has required properties
+      expect(status.docker).toHaveProperty('name');
+      expect(status.docker).toHaveProperty('installed');
+      expect(status.ollama).toHaveProperty('name');
+      expect(status.ollama).toHaveProperty('installed');
+    });
+  });
+
   describe('isSystemReady', () => {
     it('should return true when all dependencies are ready', () => {
       const status: SystemStatus = {

cli/tests/mcp-config.test.ts

@@ -155,6 +155,78 @@ describe('mcp-config', () => {
       expect(configured).toBe(true);
       expect(path).toContain('.augment');
     });
+
+    it('should return false for unknown IDE', () => {
+      const { configured, path } = checkMcpConfigured('unknown_ide');
+      expect(configured).toBe(false);
+      expect(path).toBe('');
+    });
+  });
+
+  describe('configureMcpForIdes', () => {
+    it('should configure multiple IDEs', async () => {
+      const { configureMcpForIdes } = await import('../src/lib/mcp-config.js');
+      const results = configureMcpForIdes(['augment', 'cursor']);
+
+      expect(results.size).toBe(2);
+      expect(results.get('augment')?.success).toBe(true);
+      expect(results.get('cursor')?.success).toBe(true);
+    });
+
+    it('should handle mixed valid and invalid IDEs', async () => {
+      const { configureMcpForIdes } = await import('../src/lib/mcp-config.js');
+      const results = configureMcpForIdes(['augment', 'invalid_ide']);
+
+      expect(results.size).toBe(2);
+      expect(results.get('augment')?.success).toBe(true);
+      expect(results.get('invalid_ide')?.success).toBe(false);
+    });
+  });
+
+  describe('IDE config paths', () => {
+    it('should return correct path for cursor', () => {
+      const cursorConfig = IDE_MCP_CONFIGS.cursor;
+      expect(cursorConfig.getConfigPath()).toContain('.cursor');
+      expect(cursorConfig.getConfigPath()).toContain('mcp.json');
+    });
+
+    it('should return correct path for claude (CLI)', () => {
+      const claudeConfig = IDE_MCP_CONFIGS.claude;
+      expect(claudeConfig.getConfigPath()).toContain('.claude.json');
+    });
+
+    it('should return correct path for claude-desktop on darwin', () => {
+      const claudeDesktopConfig = IDE_MCP_CONFIGS['claude-desktop'];
+      const path = claudeDesktopConfig.getConfigPath();
+      // On darwin (mocked), should be in Library/Application Support
+      expect(path).toContain('claude_desktop_config.json');
+    });
+
+    it('should return correct path for gemini on darwin', () => {
+      const geminiConfig = IDE_MCP_CONFIGS.gemini;
+      const path = geminiConfig.getConfigPath();
+      expect(path).toContain('gemini');
+      expect(path).toContain('gemini_mcp_settings.json');
+    });
+  });
+
+  describe('configureMcpForIde edge cases', () => {
+    it('should handle invalid JSON in existing config', () => {
+      const configPath = IDE_MCP_CONFIGS.augment.getConfigPath();
+      mkdirSync(join(TEST_HOME, '.augment'), { recursive: true });
+      writeFileSync(configPath, 'invalid json content');
+
+      const result = configureMcpForIde('augment');
+      // Should create new config since existing is invalid
+      expect(result.success).toBe(true);
+    });
+
+    it('should create cursor config in correct location', () => {
+      const result = configureMcpForIde('cursor');
+      expect(result.success).toBe(true);
+      expect(result.path).toContain('.cursor');
+      expect(existsSync(result.path)).toBe(true);
+    });
   });
 });