-
Notifications
You must be signed in to change notification settings - Fork 689
Support @ symbol in column names with backticks and qualified syntax #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
9
commits into
develop
Choose a base branch
from
copilot/fix-json-column-query
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+441
−352
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a0bf2ef
Initial plan
Copilot 26a1f71
Initial investigation: Created test file for issue #884 (@symbol in c…
Copilot f75aeff
Changes before error encountered
Copilot 471aa0b
Merge branch 'develop' into copilot/fix-json-column-query
mathiasrw d6ddc0d
Fix test884: Use arrow functions and test qualified @column syntax
Copilot b9c9fb6
Merge branch 'develop' into copilot/fix-json-column-query
mathiasrw cd3f570
Merge branch 'develop' into copilot/fix-json-column-query
mathiasrw 9c44576
Add test for @ symbol in middle/end of column names
Copilot 2e221ee
Merge branch 'develop' into copilot/fix-json-column-query
mathiasrw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is the original intent? Is the point not to have @ in any part of the name?
also: how does it affect the current graph select notation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change on line 1184 adds support for qualified column references with @ (e.g.,
table.@column). This allows accessing JSON columns with @ when using table aliases. For unqualified references, backticks are still required (e.g.,`@version`) to avoid conflicts with SQL Server variable syntax (@variable).Regarding graph select notation: The
AT Literalsyntax used in graph selectors (lines 651-658) is preserved and unaffected. This change only adds a new alternative in the Column rule for qualified column names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the @ is in the middle of the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backticks handle
@anywhere in the column name (beginning, middle, or end). Added test in commit 9c44576 demonstrating this:`col@middle`✅ works`end@`✅ works`@start@end`✅ worksThe
BRALITERALtoken (backticks) accepts any characters, so no grammar changes are needed for this case.