Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More professional logger #1

Open
Anduin2017 opened this issue Nov 24, 2020 · 2 comments
Open

More professional logger #1

Anduin2017 opened this issue Nov 24, 2020 · 2 comments

Comments

@Anduin2017
Copy link
Member

No description provided.

@MESOLONELY
Copy link
Member

MESOLONELY commented Dec 9, 2020

Is anyone working on this issue? If not, I will proceed

@Anduin2017
Copy link
Member Author

Currently, we are using Console.WriteLine to debug. Console.WriteLine may cause some issue because the target user may already built a logger for them own.

Usually, in C#, we are using ILogger interface.

https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.ilogger?view=dotnet-plat-ext-5.0

So we can change our logs to use ILogger. While I started to work on this, I found it hard for the user to pass in the logger. Also we didn't use a dependency injection framework. So it's also hard for us to change.

Please carefully consider the way we use it before getting started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants