-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local deployment using deploy-contract.js no longer works #77
Comments
Might have been this commit here: |
@mujahidkay had a good idea, he suggested we consider I support it, as it seems easy to accidentally break if its not a part of our pipelines. Would love team thoughts |
The |
absolutely. As I am fond of saying: you don't have to test everything. Just the stuff you want to work. :) And ci is all about testing to avoid regressions. In my work on #61, each time I found a problem with deployment to a chain, I reduced it to an ava unit test before fixing it. That makes for much faster iteration time. We have a docs issue to encourage smart contract devs to do likewise: Reducing to an ava test requires factoring out ambient authority--that is, applying the OCap Discipline part of our style guide, which is one of my favorite things to do. :)
So I moved several bits of code out of the |
Wait... now I'm confused. Isn't When I worked on #61, I didn't see any use of |
Agreed 100% - let's do it. |
@dckc the command to run yarn node scripts/deploy-contract.js --install ${PWD}/src/orca.contract.js,${PWD}/src/orca.proposal.js --eval /root/src/orca.proposal.js This command has always been the The inspiration came from this command in It's also never been in CI, hence why we are suggesting to include it |
@amessbee I'm not sure what you're confused by on this, can you be more specific? |
Yes, but for what purpose? Why deploy the contract to a local chain that doesn't have IBC connections to other chains? |
@Jovonni below is the definition of
|
I thought this was being deployed to a kube pod with IBC connection to |
The way we do that in CI is with Again, I ask: Isn't deploy-contract.js subsumed by deploy-cli.js? |
The local chain does have IBC connections to other chains. |
If it is "subsumed", that is news to me, we originally grabbed it from here: start-contract-mint:
yarn node scripts/deploy-contract.js \
--install src/sell-concert-tickets.contract.js \
--eval src/platform-goals/board-aux.core.js \
--eval src/sell-concert-tickets.proposal.js By this, I would assume its not subsumed by |
If the local chain stuff does have IBC to other chains, what distinguishes it from the What are we trying to do with Is there some important feature that depends on What bad thing happens if we just get rid of |
will study |
@dckc kudos, you were right on track! 😂 Thank you and @0xpatrickdev |
The changes referenced in #54, and implemented in #37 (comment) might have been reverted during a recent merge:
Evidence:
The text was updated successfully, but these errors were encountered: