Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VALIDATORADDR is misnamed #212

Open
turadg opened this issue Jan 14, 2025 · 0 comments
Open

VALIDATORADDR is misnamed #212

turadg opened this issue Jan 14, 2025 · 0 comments

Comments

@turadg
Copy link
Member

turadg commented Jan 14, 2025

Problem

from @anilhelvaci in Agoric/agoric-sdk#10835 (comment)

VALIDATORADDR refers to the validator's "Application Key" whereas VALIDATOR_ADDRESS refers to the validator's "CometBFT Key". See https://hub.cosmos.network/main/validators/validator-faq.html#what-are-the-different-types-of-keys.

For example:

  • VALIDATORADDR: agoric1estsewt6jqsx77pwcxkn5ah0jqgu8rhgflwfdl
  • VALIDATOR_ADDRESS: agoricvaloper1estsewt6jqsx77pwcxkn5ah0jqgu8rhge8aq37

Solution

In env_setup.sh,

  • rename VALIDATORADDR to DELEGATOR_ADDRRESS
  • define actual VALIDATOR_ADDRESS

Update all proposals to handle this change

Work-around

Proposals have had this in their test.sh,

# XXX correct misnaming
DELEGATOR_ADDRRESS=$VALIDATORADDR
VALIDATOR_ADDRESS=$(agd query staking delegations "$DELEGATOR_ADDRRESS" --output json | jq -r ".delegation_responses[0].delegation.validator_address")
export VALIDATOR_ADDRESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant