copy 'test' dir only in TEST stage #213
Conversation
turadg
force-pushed
the
115-exclude-test
branch
from
f2a7725 to
383df33
Compare
turadg
force-pushed
the
115-exclude-test
branch
from
9904136 to
8224819
Compare
| @@ -97,7 +100,7 @@ FROM ghcr.io/agoric/agoric-sdk:${sdkImageTag} as execute-${proposalName} | |||
| WORKDIR /usr/src/upgrade-test-scripts | |||
|
|
|||
| # base is a fresh sdk image so set up the proposal and its dependencies | |||
| COPY --link --chmod=755 ./proposals/${path} /usr/src/proposals/${path} | |||
| COPY --exclude=test* --link --chmod=755 ./proposals/${path} /usr/src/proposals/${path} | |||
There was a problem hiding this comment.
I'm confused by this. in agoric-3-proposals/proposals/*, we generally don't have test code segregated into test/ directories. Will this change catch files named test.sh and foo-test.js? Are we expecting to make test/ subdirectories in most proposals?
There was a problem hiding this comment.
we generally don't have test code segregated into test/ directories
True. To gain the benefits of this change those proposals will have to do the segregation. But it's moot for proposals in this repo as we don't iterate on those tests. The value is in agoric-sdk/a3p-integration/proposals.
Will this change catch files named test.sh and foo-test.js?
Good question. This glob gets test.sh but not foo-test.js. I expected Ava tests (in which 'test' does not lead the filename) to go in a test folder. We could glob more but have to be careful. *test* would exclude files that aren't necessarily for testing, like greatest.
If we want to be really safe we could --exclude=test --exclude=test.*. Oh, and --exclude=*.test.* should be safe and cover Ava test files (assuming the Ava default glob).
There was a problem hiding this comment.
Turns out the Crabble build uses Ava to execute its eval. That's not a good design but is an example of a "test*" that is needed before test stage.
I'm trying now with the multiple globs.
Closes: #115
image building process
This omits
test*from non-test images. Presumably no other stages depend on "test*" files. CI passing here is evidence of that in the a3p images. If any are affected in downsteam repos we can correct them.